Hi

I'm the mantainer of Ubercart Terms Of Service which I think that does exactly the same as your module:
http://drupal.org/project/uc_termsofservice

Can you explain the differences?

Thanks

Comments

nicholas.alipaz’s picture

nicholas.alipaz commented

Interesting, I hadn't seen that module. However, there are some differences that I can see.

  • The user can have as many node panes as they like. They could essentially create hundreds of node panes to be associated with various products.
  • This module allows selecting a product to validate the contents of the shopping cart against and determine whether the node should be shown or not.
  • The checkbox is optional, leaving users to simply show some content in a pane without the need of an agreement.
  • No styling (i.e. - overflow scrolling) is done to the panes. They are simply inserted into a pane and left for the user to determine how to deal with them
  • Future update will allow users to specify product classes OR product id's for a node pane to be validated against

That being said, there are some striking similarities and most definitely some reproduced functionality. I might suggest us merging our efforts and potentially bettering the projects as a whole through teamwork. I think this one is more appropriately named, since it does not directly infer that it is for TOS. Let me know your input on the matter.

nicholas.alipaz’s picture

nicholas.alipaz commented

BTW, if you want to try this one out... I found a bug or two in it this morning and committed the fixes. Please grab the latest copy. If the dev is updated it will read Feb 11 for the date, if not then checkout the cvs version.

pcambra’s picture

pcambra
he/him
Primary language Spanish
commented

Hi!

I totally agree we should merge efforts in these projects, even there is room for cart node panes & checkout node panes.

UC terms of service includes one node only for both checkout (optional/required) & cart (optional) but when I was working in it, I found that would be great to add any node and any quantity regardless of the use of this node, terms of service or whatever purpose wich I think your module is fo.

Let's keep this issue open for future collaboration, now I'm overhelmed by organizing drupalcamp in spain but I'll come back in a couple of weeks to see what we can do with this :)

Thanks for the feedback!

nicholas.alipaz’s picture

nicholas.alipaz commented

sounds great. I look forward to seeing how we might be able to collaborate. I will continue with some bug fixes and maybe some additional support for panes in cart and pane validation by product class. Until then... ;)

nicholas.alipaz’s picture

nicholas.alipaz commented
Status: Active » Closed (works as designed)

closing for now, please reopen if you want to collaborate or merge the projects.

pcambra’s picture

pcambra
he/him
Primary language Spanish
commented
Status: Closed (works as designed) » Active

Sure I do, but I think that the "primary" differences between the projects are the name (yours is more generic) and the checkbox option, that in terms of service is not a setting and in node pane it is.
Uc terms of service has more than 600 sites using it, so maybe the the logical thing would be to keep it and maybe evolve this one, I'm not sure.

nicholas.alipaz’s picture

nicholas.alipaz commented

I am thinking perhaps some way of doing a migration on update/install of this one. Moving data from your tables to this one if they exist. We just need to create a good upgrade/install path. I will give it more thought and post here as I get a chance.

pcambra’s picture

pcambra
he/him
Primary language Spanish
commented

I don't think that a migration would make sense with the current status of the modules.
What do you think about using your namespace for a Drupal 7 more generic Ubercart module for getting all the node extra panes working in one generic project? Even this one http://drupal.org/project/uc_webform_pane

nicholas.alipaz’s picture

nicholas.alipaz commented

that is an option I guess. I am open to that if you prefer it. So we could just leave the current 6.x-dev as a dev and put all efforts into the 7.x version and perhaps an upgrade path for like modules to become one.

It may make the most sense however to keep the aforementioned module as a separate module. It could however become a submodule of this one if it provided a good api for hooking into. It is just that webforms are a bit of a different breed of node IMO and would likely require additional processing not necessary to have in this module.

aireworth’s picture

aireworth commented

I might have got this wrong, but is there not a difference between the two modules in that this one allows a different node to become a pane for each product? Does UC ToS do that?
I'm selling events. Each event is different. I possibly want per product configurable checkout panes.

Colin

arski’s picture

arski commented

Hey guys,

As far as I can see there is one major difference:

UC Node Panes allows to show a node on checkout, without collecting any additional data.

UC ToS allows to show one (or multiple? not essential) fields and collect one field of data (the checkbox).

Now while these two projects could be possibly combined, I would not see uc_webform_pane as something quite similar. In fact, there are 3 further modules that are meant to add functionality to the checkout process, which are:

UC Webform Checkout Pane - collect data during checkout as webform submissions
UC CCK Checkout Pane - collect data during checkout as nodes

UC Product Checkout Panes - enable/disable checkout panes based on the products in your cart.

So if you combine one of the first two with the last one, you'll have a nice little combination to collect as much extra data as you like.

Disclaimer: I'm the maintainer of the 3 latter modules, so forgive me if I'm advertising them too much ;)