When I updated from the 2009-Oct-23 version to the 2010-Feb-07 version it broke my page layout. I discovered that it fixed it if I removed line 1692 from swftools.module:

$html .= '</div>' . "\n";

After a little more poking around, I noticed that there used be a corresponding opening div on line 1637 in the 2009-Oct-23 version of swftools.module

$html  = '<div class="swftools">' . "\n";

Is there something that needs fixing there, or did I manage to break my page layout all by myself?

Thanks for the great module.

Comments

Stuart Greenfield’s picture

Stuart Greenfield commented

Sounds like a mistake on my part - let me check it out.

Out of interest, how are you finding the 6.x-3.x version? You'll have presumably picked up that the player and JavaScript locations have moved. Not sure if you're explored the new features yet (some are unstable, some are behind the scenes) so may have not been discovered?

Any comments would be welcome as I'd like to make this release a good one as it's been a while since there was an SWF Tools release!

Stuart Greenfield’s picture

Stuart Greenfield commented
Status: Active » Fixed

Yep - I had deleted the swftools wrapper as it wasn't serving any useful purpose since a generic wrapper is added elsewhere, and I missed the closing div. It will be fixed on this branch at the next commit.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.