I've also posted this into the "newspapers on drupal group", but now going thru the code, it seems that this is an issue.

My problem is, that I can't seem to find a way to have different ad sizes on different pages with the CASAA using apt_plugin. I hope there are some members of the Yahoo!'s Newspaper Consortium here.

Let say we have a following setup:
Homepage - 2 leaderboards, 2 boxads
The rest - 2 leaderboards, 2 skyscrapers

If I define all 6 ads in the Global settings of the plugin, I can see all the ads/blocks being available, but the yld_mgr init code in the
header is wrong, since it initializes all 6 slots, and not just 4 being used on the page.

This will result in an overdelivery of the ads.

I'm not sure how many sites are actually using APT plugin and CASAA, but

CommentFileSizeAuthor
#3 apt_plugin-20100219.patch34.4 KBcntlscrut
#1 apt_plugin_module.txt48.47 KBcholoepus

Comments

choloepus’s picture

choloepus commented
StatusFileSize
new apt_plugin_module.txt48.47 KB

Here is the modified apt_plugin.module.

This adds a list of checkboxes to the add/edit mapping tab.
The checkbox list will consist of all globally defined ad positions, and in this way, this lets you choose what ads to run on the page.

cntlscrut’s picture

cntlscrut commented
Status: Active » Needs review
cntlscrut’s picture

cntlscrut commented
Assigned: Unassigned » cntlscrut
Status: Needs review » Patch (to be ported)
StatusFileSize
new apt_plugin-20100219.patch34.4 KB

Here's a patch containing the fixes for this issue. The file also contains updates to the Topic Id list.

An official port release is on the way.

TylerE’s picture

TylerE commented

This patch doesn't apply cleanly...hunk #2 fails

TylerE’s picture

TylerE commented
Status: Patch (to be ported) » Needs work

Ok, the failed hunk doesn't seem to really matter because it's only formatting changes. However, I've found a more serious issue. The column allocated for the serialized data is only 300 chars, and it's very easy to overflow that if you have several ad slots defined. This causes total loss of all data for that mapping. I went in to our DB and changed the column to 1000 chars, and that seems to have fixed it.

alter table casaa_context_mapper modify casaa_value varchar(1000);
cntlscrut’s picture

cntlscrut commented
Status: Needs work » Fixed

- db table column has been adjusted.

- selectable slots has been officially ported into the module.

changes available in 6.x-1.10-beta2

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

choloepus’s picture

choloepus commented

Just got to trying out a 6.x-1.12-rc1 version.
I see the ad selection in the mapping form, and I can select the appropriate sizes, but all of the ads are served anyways.

I think I'll do clean install of drupal 6 and casaa and see what is happening there...

choloepus’s picture

choloepus commented

1.12 seems to be broken for me

choloepus’s picture

choloepus commented
Status: Closed (fixed) » Needs review

Nevermind.

I've had a misconfigured cacherouter module, which resulted in the stale cache_form and adding/changing the mapping was impossible.

There is some leftover code from the debugging:

Line 194, casaa.module,
if ($uri == '/') {
var_dump('is front');
//note the extra char at the beginning.
// this is to keep the substr value from lopping off the
// start of our token.
$uri = '[[front]';
}

cntlscrut’s picture

cntlscrut commented
Status: Needs review » Fixed

Debug code has been removed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.