pm-updatecode unable to update disabled projects (update_advanced enabled)

it seems a problem related to the fact that feeds is disabled. It is theorically imposible because drush 3.x should show:

 feeds                           Unknown            Unknown           No version information found (if you have a CVS 
                                                                      checkout you should install CVS Deploy module)  

the disabled-modules thing comes because of the interaction of update_advanced when drush is unable to find the project on disk and hits:

commands/pm/updatecode.pm.inc:      return drush_set_error('DRUSH_PM_UPDATING_PATH_NOT_FOUND', dt('The !project directory could not be found within the !types directory at !full_project_path, perhaps the project is enabled but has been deleted from disk.', array('!project' => $project['name'], '!type' => $project['project_type'], '!full_project_path' => $project['full_project_path'])));

It seems to me the project was disabled in a second terminal when pm-update was fetching data from updates.drupal.org and before the call to update_advanced_update_projects_alter(), that sets the project type to disabled-modules if it is disabled. Or perhaps older versions of drupal 6.x checked also for disabled modules.

I haven't used update_advanced before. Now I've seen it adds this option to update settings: Check for updates of disabled modules and themes. With that checked the problem is reproducible.

The basic project path is not available, perhaps the disabled-theme is enabled but has been deleted from disk.     [error]
An error occurred at function : drush_pm_updatecode                                                                [error]

Great job jonhatthan, thanks ;)

I love drush :)

Oskar

Yes jonhattan thanks for your time and your help !!

I think this just needs some documentation somewhere to instruct users to not use "Check for updates of disabled modules and themes" when using update_advanced.

Wow it seems I have a fanclub :p

We already check for disabled projects requested but it is neutralized by update_advanced. With attached patch (untested) this situation is improved, but I think it will still fail if a disabled project has a update available, although it was not explicitly requested.

I also think pm-updatecode is almost ready to be compatible with update_advanced. It is only needed to have the path to the extensions in $project['includes'] (or similar).

Now that this feature of update_advanced is in Drupal 7 core's Update Manager module (admin/reports/updates/settings), this is a major bug.

My error message is slightly garbled but it's definitely the same situation:
"The ctools project path is not available, perhaps the module-disabled[error]
is enabled but has been deleted from disk."

Drupal is checking the status of disabled modules, and drush attempts but is unable to update disabled modules and so the entire drush upc fails (or actually, succeeds up to that point, but tells you it fails, and further tells you its rollbacks fail).

The patch from #9 breaks drush for me.

In any case i think the approach should be to have drush upc update disabled modules, or do not list them as needing updates at all.

I can confirm that D7 with that checkbox (admin/reports/updates/settings) is broken. Here is a replay script.

check the box at admin/reports/updates/settings
drush dl ctools-7.x-1.0-alpha1 -y
drush en ctools -y
drush dis ctools -y
drush upc ctools

Note that pm-updatecode fails with the message above.

I still think we are pretty near of being able to update disabled projects.
This patch is conservative and just get rid of disabled projects to continue with pm-updatecode as usual.

IIRC, drupal's update.php does update disabled modules so we should ideally match its behavior.

patch to update disabled projects. It works if the box is checked (d6 and d7).

Worked for the ctools test. Committed.

Follow-up issue #1033380: Non-variable passed by reference warning caused by _pm_get_update_info() for disabled modules

Just tested in D6 with latest HEAD and still receive the following error when running "drush upc" with update_advanced enabled and "Check for updates of disabled modules and themes" checked:

The views_bulk_operations project path is not available, perhaps the -module is enabled but has been deleted [error] from disk.

It is a bug introduced yesterday when fixing #1033380: Non-variable passed by reference warning caused by _pm_get_update_info() for disabled modules. Now fixed in head.

I use D7 with "Check for updates of disabled modules and themes" enabled. Using both drush 5 and 4 dev versions I still experience the error:"The xxx project path is not available, perhaps the -module is enabled but has been deleted [error] from disk." Does it happen to anyone else?

woops I have failed badly several times to correctly implement basic arithmetics. Now fixed in HEAD.

to be backported.

Maybe that patch is supposed to have something in it? :)

Sorry. Here's the diff: http://drupalcode.org/viewvc/drupal/contributions/modules/drush/commands...

Tested on version 5 and now it updates disabled modules perfectly. Thanks! :) there is still the problem of just updating a random number of modules and not all of them once. It needed passing 6 times "drush up" to make sure all modules were updated.

Backported.

http://drupal.org/commitlog/commit/2320/2cb68cdaa5cd35b93bb825d3b89c8ea9...