Attached is a first stab at adding a Media Mover mode.
It's *very* simple at the moment, but it should provide a good place to start. It currently only supports the 6.1 branch, and there are no options. It simply checks the last step in the mmfid table for an external URL to rewrite the path to, which works when you're pushing files to S3.
I'm still not totally sure what configuration options should be provided here, but I imagine I'll run into some things as I continue to test it.
| Comment | File | Size | Author |
|---|---|---|---|
| #19 | cdn_media_mover-712998-19.patch | 7.65 KB | pdrake |
| #18 | cdn_media_mover-712998-18.patch | 7.69 KB | pdrake |
| #17 | cdn_media_mover-712998-17.patch | 7.69 KB | pdrake |
| #15 | 712998-cdn_media_mover_14.patch | 8.07 KB | bcmiller0 |
| #14 | 712998-cdn_media_mover_13.patch | 8.01 KB | bcmiller0 |
Comments
Comment #1
wim leersDo we want to go with the MM 6.1 branch and not the 6.2 branch? Probably 6.1 for now because it's out there and is working?
Comment #2
msonnabaum commentedYeah, I've got 6.1 in production right now and it's pretty stable. 6.2 is still undergoing some schema changes, although the api should be pretty stable soon.
It should be pretty easy to support both for the time being.
Comment #3
srobert72 commentedSubscribing
Comment #4
wim leersLooking forward to the next version of your patch, msonnabaum :)
Comment #5
wim leersComment #6
msonnabaum commentedTHis one has some bug fixes to the media mover part, and I've also brought the admin section inline with your recent changes.
Comment #7
wim leersIs this all that is necessary to get Media Mover integration working with Media Mover 1.x? Should we support Media Mover 1.x or go right away for Media Mover 2.x support?
Comment #8
arthurf commentedI would encourage everyone who is looking at media mover at this point to use the 6.2x code. This will be the jumping off point for D7 code as well. While updating 6.1x code to 6.2x is not hard, I'm focusing all my efforts on 6.2.x at this point.
As per D7, the only major change that may or may not happen is looking at how files are stored. My plan hope is to rewrite class_media_mover_file only to rely on drupal files, but it may come as a second revision to media mover. Regardless, the API should be consistent regardless.
Comment #9
wim leersI guess I should mark this as 'needs work' then, since the patch currently only supports MM 1 :)
Note that I won't be able to maintain Media Mover support in CDN integration. It would be too hard to support for me. It is a chance for you Media Mover guys though to reach to a larger audience and thus possibly get more sponsorship for your work! :)
If that's something you're not willing to do, that's fine. I just know I won't be able to support this on the side, next to my other Drupal projects and master studies.
Comment #10
wim leersComment #11
bcmiller0 commentedsubscribe,
like to see this on latest version of CDN
Comment #12
bcmiller0 commentedHere is a attempt to upgrade mark's patch to work with current release of CDN DRUPAL-6--2-0-RC2 and media mover version DRUPAL-6--1-0-BETA7. I should be able to test it quite a bit next week to ensure works fine.
Patch will still need work for media mover 2, but we arent' yet on that.
Comment #13
bcmiller0 commentedsimple fixes. Hope to get this fairly well tested this week.
Comment #14
bcmiller0 commentedsigh, table missing char "_" in name.
Comment #15
bcmiller0 commentedThis seems to be working fine.
Comment #16
wim leersPlease create a cdn.mediamover.inc file with the logic for Media Mover. Makes it easier to maintain!
Comment #17
pdrake commentedRealizing that this still isn't a cdn.mediamover.inc file as requested, attached is a patch which fixes a minor PHP notice which occurs when returning $servers when it is undefined.
Comment #18
pdrake commentedThe attached patch fixes some Drupal coding standards problems in the previous patch.
Comment #19
pdrake commentedOne more. Simplified the fix.
Comment #20
wim leersI hate to say this, but I have to.
Considering the Media Mover uptake at http://drupal.org/project/media_mover (693 sites, 45 of which on D7) and the fact that it's actually declining, I'm not sure anybody would use CDN + Media Mover?
If the above statement is truthful, which I think and hope it is, then it makes more sense to include this in the Media Mover module or in a separate "Media Mover CDN" module.
Comment #21
wim leersI'd be happy to add the hooks necessary to be able to add Media Mover support from within a "Media Mover CDN" module, but only if this is actually going to be used.
I'm afraid it might make more sense to integrate with the Storage API module instead (#875632: Storage API + CDN), but even in that easier to use system, there appears to be very little interest.
Moving to the Media Mover issue queue, to make sure this issue is not forgotten.
Comment #22
bcmiller0 commentedFYI, Now that EC2 cloud front does origin pull, our need for media mover went away in regards to CDN. So we are no longer using this, as at the time we originally started using cloud-front we needed a way to move our content to S3 for cloud front CDN.
Comment #23
wim leersThanks for letting me know! That seems to confirm the fact that this is a de facto dead issue.