Attached is a patch that adds support for:

  • pager elements
  • pause
  • pager pause
  • pager location

Patch with `patch -p1 < views-cycle-pager.patch`

New options will appear when configuring the View display style.

And thanks for making this module, works great and will save plenty of time in the future!

Comments

jon nunan’s picture

Patch works for me, but I think the UI is a little confusing. Should probably have the existing 'thumbnail field' and these new pager options grouped together in the pager settings fieldset.

Also I know this isn't from your patch but if the fields were moved into that fieldset, I think 'transition event' should be moved to the transition fieldset.

AdrianB’s picture

Subscribing.

jdwfly’s picture

Status: Needs review » Reviewed & tested by the community

+1

Patch applied fine for me and its working great

trevortwining’s picture

Patch applied and working fine here. Kind of indifferent about the comments in #1, could go either way for me.

akaserer’s picture

works great. good job. thanks, thats exactly what i need

bobooon’s picture

StatusFileSize
new802 bytes

Works good except the pager is wrapped inside a unordered list tag. This just changes that from <ul> to <div> for proper formatting.

rickvug’s picture

.

gg4’s picture

.

ultimike’s picture

StatusFileSize
new8.07 KB

One of our clients also needed a Pause/Resume button/link - I went ahead and added this functionality to this patch as well.

-mike

grendzy’s picture

Category: bug » feature
Status: Reviewed & tested by the community » Needs work

I like the patch in #0, though agree that the additional form element would make sense in the 'Pager settings' fieldset.

Also, none of these patches are correctly formatted.

karlshea’s picture

Status: Needs work » Needs review
StatusFileSize
new5.6 KB

I tried cleaning up the patch a bit, and moving some stuff around in fieldsets like was suggested.

I didn't add in the Pause/Resume buttons both because I think it's a separate issue, and because I think it needs more work. For instance, leaving it disabled still inserts the Pause link in the JS file.

deviantintegral’s picture

Status: Needs review » Needs work
+    $form['pager']['pager'] = array(
+      '#type' => 'checkbox',
+      '#title' => t('Enable Pager'),
+      '#default_value' => $this->options['pager']['pager'],
+      '#description' => t(''),
+      '#required' => TRUE,
+    );

Why is the description empty?

Otherwise, this patch is working reasonably well for me.

deviantintegral’s picture

Priority: Critical » Major

A further todo on this patch - as is, it's unclear what skins are supposed to do in terms of the pager_location variable. Things break if your skin is set up with a "before" pager and the user selects "after" in the views style.

Bumping down from critical as this isn't a bug.

deviantintegral’s picture

StatusFileSize
new4.74 KB

Here is an updated patch that:

  • Moves the pager event to the pager fieldset. This caused problems with the pager event being "null". This just fixes the form, the settings work had all ready been done in #11.
  • Sets the empty description from above to "Determine if the numeric pager is enabled."

The UI is still a little confusing, especially in relation to "numeric" vs "thumbnail" pagers.

basvredeling’s picture

Patch from #14 works great. I would love to have this commited.
Only thing I noticed is that the pager doesn't work on attachment displays.