Needs work
Project:
Views cycle
Version:
6.x-1.0-beta4
Component:
Code
Priority:
Major
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
12 Feb 2010 at 22:03 UTC
Updated:
21 Sep 2010 at 22:56 UTC
Jump to comment: Most recent file
Comments
Comment #1
jon nunan commentedPatch works for me, but I think the UI is a little confusing. Should probably have the existing 'thumbnail field' and these new pager options grouped together in the pager settings fieldset.
Also I know this isn't from your patch but if the fields were moved into that fieldset, I think 'transition event' should be moved to the transition fieldset.
Comment #2
AdrianB commentedSubscribing.
Comment #3
jdwfly commented+1
Patch applied fine for me and its working great
Comment #4
trevortwining commentedPatch applied and working fine here. Kind of indifferent about the comments in #1, could go either way for me.
Comment #5
akaserer commentedworks great. good job. thanks, thats exactly what i need
Comment #6
bobooon commentedWorks good except the pager is wrapped inside a unordered list tag. This just changes that from
<ul>to<div>for proper formatting.Comment #7
rickvug commented.
Comment #8
gg4 commented.
Comment #9
ultimikeOne of our clients also needed a Pause/Resume button/link - I went ahead and added this functionality to this patch as well.
-mike
Comment #10
grendzy commentedI like the patch in #0, though agree that the additional form element would make sense in the 'Pager settings' fieldset.
Also, none of these patches are correctly formatted.
Comment #11
karlsheaI tried cleaning up the patch a bit, and moving some stuff around in fieldsets like was suggested.
I didn't add in the Pause/Resume buttons both because I think it's a separate issue, and because I think it needs more work. For instance, leaving it disabled still inserts the Pause link in the JS file.
Comment #12
deviantintegral commentedWhy is the description empty?
Otherwise, this patch is working reasonably well for me.
Comment #13
deviantintegral commentedA further todo on this patch - as is, it's unclear what skins are supposed to do in terms of the pager_location variable. Things break if your skin is set up with a "before" pager and the user selects "after" in the views style.
Bumping down from critical as this isn't a bug.
Comment #14
deviantintegral commentedHere is an updated patch that:
The UI is still a little confusing, especially in relation to "numeric" vs "thumbnail" pagers.
Comment #15
basvredelingPatch from #14 works great. I would love to have this commited.
Only thing I noticed is that the pager doesn't work on attachment displays.