Posted by agentrickard on February 12, 2010 at 10:20pm
| Project: | Domain Access |
| Version: | 6.x-2.x-dev |
| Component: | Code |
| Category: | feature request |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed (fixed) |
| Issue tags: | favorite |
Issue Summary
Here's an experimental module that domain-enables _all_ forms that use system_settings_form().
Might not work in all cases, but may be worth a look.
| Attachment | Size |
|---|---|
| domain_settings.zip | 3.7 KB |
Comments
#1
And a better, sexier version.
#2
Nice I'll try and give this a roll this weekend as I have some localized patches for variable_set to do this on a case by case basis.
#3
subscribing
#4
Subscribing. Going to test it tonight.
#5
Note that this only works with forms that don't modify the handling of system_settings_form. Certain core forms (like forums, and date/time) simply won't work.
#6
I installed the new module and tried it out using the form for the Google Analytics module. Everything worked great. This is a really nice addition both in terms of ease of use and in terms of operating in a way that will be maximally intuitive to new users. Following up on the update to your blog post I'd add a vote for rolling this into Domain Conf.
One minor suggestion (if it's easy) would be to have the Save Settings For option default to the active domain. This would maximize the intuitive nature of the interface - the user goes to the appropriate settings page from the domain of interest, is shown the current settings for that domain, and then (without changing from the default) saves those settings for that domain - and would also reduce the number of instances where the settings for the current domain accidentally overwrite those for the primary domain.
#7
One minor suggestion (if it's easy) would be to have the Save Settings For option default to the active domain.There is a setting for this on the Domain module settings page. It's just not documented. The theory is that some will prefer the 'normal' behavior, and some won't.
#8
If someone would write up some documentation.....
#9
Thanks, I should have looked around a little more, and thanks again for another great addition to DA.
I can write a first draft of the documentation (apparently after I look around a little more).
#10
Tagging
#11
Here is a first attempt at documentation for Domain Settings. It basically just puts together the information from the original blog post and from the queue. I tried to follow the style and structure of the README.txt files for Domain Conf and Domain Nav. Section 2.2 was something I didn't have an example for, but it seemed important to include an explicit description of the cases where the domain-specific settings won't work.
#12
Very nice.
So, submodule, or part of Domain Conf? I think submodule, so users can disable it separately.
#13
I agree - separate submodule.
#14
And I think I will go against my earlier pronouncements and simply add this to 6.x.2.2.
#15
Committed to 6--2 and HEAD.
#16
Is this module included in 6.x-2.2 ? I am using 2.2 and I don't see it. On DA page there is no 6.x-2.x-dev available, which is why I am a bit confused on the status of this settings module/patch.
#17
It's included. If you don't see it on the modules page you should clear the caches and see if that helps.
#18
Found it now, thanks.
#19
Automatically closed -- issue fixed for 2 weeks with no activity.
#20
@#1 your archive contains a lot of MacOS junk.