Closed (fixed)
Project:
Domain
Version:
6.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
12 Feb 2010 at 22:20 UTC
Updated:
6 Aug 2010 at 10:08 UTC
Jump to comment: Most recent file
Comments
Comment #1
agentrickardAnd a better, sexier version.
Comment #2
marcingy commentedNice I'll try and give this a roll this weekend as I have some localized patches for variable_set to do this on a case by case basis.
Comment #3
antiorario commentedsubscribing
Comment #4
Aniara.io commentedSubscribing. Going to test it tonight.
Comment #5
agentrickardNote that this only works with forms that don't modify the handling of system_settings_form. Certain core forms (like forums, and date/time) simply won't work.
Comment #6
croryx commentedI installed the new module and tried it out using the form for the Google Analytics module. Everything worked great. This is a really nice addition both in terms of ease of use and in terms of operating in a way that will be maximally intuitive to new users. Following up on the update to your blog post I'd add a vote for rolling this into Domain Conf.
One minor suggestion (if it's easy) would be to have the Save Settings For option default to the active domain. This would maximize the intuitive nature of the interface - the user goes to the appropriate settings page from the domain of interest, is shown the current settings for that domain, and then (without changing from the default) saves those settings for that domain - and would also reduce the number of instances where the settings for the current domain accidentally overwrite those for the primary domain.
Comment #7
agentrickardThere is a setting for this on the Domain module settings page. It's just not documented. The theory is that some will prefer the 'normal' behavior, and some won't.
Comment #8
agentrickardIf someone would write up some documentation.....
Comment #9
croryx commentedThanks, I should have looked around a little more, and thanks again for another great addition to DA.
I can write a first draft of the documentation (apparently after I look around a little more).
Comment #10
agentrickardTagging
Comment #11
croryx commentedHere is a first attempt at documentation for Domain Settings. It basically just puts together the information from the original blog post and from the queue. I tried to follow the style and structure of the README.txt files for Domain Conf and Domain Nav. Section 2.2 was something I didn't have an example for, but it seemed important to include an explicit description of the cases where the domain-specific settings won't work.
Comment #12
agentrickardVery nice.
So, submodule, or part of Domain Conf? I think submodule, so users can disable it separately.
Comment #13
croryx commentedI agree - separate submodule.
Comment #14
agentrickardAnd I think I will go against my earlier pronouncements and simply add this to 6.x.2.2.
Comment #15
agentrickardCommitted to 6--2 and HEAD.
Comment #16
TimAlsop commentedIs this module included in 6.x-2.2 ? I am using 2.2 and I don't see it. On DA page there is no 6.x-2.x-dev available, which is why I am a bit confused on the status of this settings module/patch.
Comment #17
antiorario commentedIt's included. If you don't see it on the modules page you should clear the caches and see if that helps.
Comment #18
TimAlsop commentedFound it now, thanks.
Comment #20
pounard@#1 your archive contains a lot of MacOS junk.