mp_file renaming files

Hi keereel, I'm on the verge of a 6.x production release, so this is a good time to get this incorporated. Let's see if we can get this and your other request(s) marked off as "fixed".

Unfortunately you will have to get the latest dev release (you might have to wait until this afternoon for it to come out) as I've made a few minor changes to help incorporate your request. Your request should now be supported by a new "hook" which will hopefully allow you to never have to make these changes again :-).

Do you have any custom modules you've written for your site? I typically have at least one called "site_helper" where I can put hooks and Drupal modifications, etc. If you need help setting one up I can help but you can probably find a lot of resources online which can help you figure this out.

In this "site_helper" module (or whatever you call it) paste in the following hook function:

/**
 * Implements hook_mp_file_name().
 *
 * Returns the filename to be used for this feature.  
 */
function site_helper_mp_file_name($dir, $file_name, $file_name_ext, $node_id, $title) {
  $node_sanitized_title = preg_replace('/[^0-9a-z\.\_\-]/i', '', $title);
  
  $new_file_name = $node_id . "_" . $file_name . "." . $file_name_ext;

  // We could now return $new_file_name but first let's rename it if this file name already exists.
  // NB: $file_name also has a counter in it for files in the temp directory
  $i_file = 0;
  while (file_exists($dir . $new_file_name)) {
    $i_file++;
    $new_file_name = $node_id . "_" . $file_name . "_" . sprintf("%03d", $i_file) . "." . $file_name_ext;
  }

  return $new_file_name;
}

If you leave the above code unmodified, mp_file should behave exactly the same. At this point you can modify this function to do what you want.

So here is some untested code that might work for you:

/**
 * Implements hook_mp_file_name().
 *
 * Returns the filename to be used for this feature.  
 */
function site_helper_mp_file_name($dir, $file_name, $file_name_ext, $node_id, $title) {
  if (module_exists ('transliteration')) {
    $transliterated = transliteration_get ($title);
  }
  $node_sanitized_title = preg_replace('/[^0-9a-z\.\_\-]/i','', $transliterated);
  
  $node = node_load($nid);
  $new_file_name = $node->uid .'_'. $node_id .'_'. $node_sanitized_title .'.'. $file_name_ext;

  return $new_file_name;
}

The above may not work and probably doesn't do exactly what you want. But hopefully it's enough to get you started. Let me know if I can help.

keereel, looks reasonable to me. However, I have a few thoughts:

* Sorry for making you download marketplace over and over, but make sure you have the Feb 14th release or later. I made a minor change specifically for you, that is included in that release and is consistent with post #1.

* I didn't test the code in #1 but you should be able to get the uid from the nid, right? Did you try that (see #1)?

* You should be able to do this all outside mp_file in your own custom module using hook_mp_file_name. I would imagine this would be preferable to editing mp_file.module unless you need faster execution or something? I think the second code snippet in #1 does almost everything you describe (it made need a little work but I think it's all there).

I look forward to hearing your thoughts. Cheers.

Well there is always something wrong with untested code :-). I used node_load($nid) but it should have been node_load($node_id). I have attached a custom module that does what you have requested. Here's all it is:

function keereel_mp_file_name($dir, $file_name, $file_name_ext, $node_id, $title) {
  $node = node_load($node_id);
  $new_file_name = $node->uid .'_'. $node_id .'_'. $file_name .'.'. $file_name_ext;

  return $new_file_name;
}

To use the attached module just put it in your modules folder and enable it just like you do any other module. Let me know how it goes.

No problem. Yes keereel.zip is site_helper. Although I changed the module name from "site_helper" to "keereel". You can change it back to site_helper if you want. Good luck.

Great! Try $node->title.

Hello,

I noticed that you are modifying the code to rename files and I'd like to know whether you tried to use the filefield paths module to achieve this.

I am currently using filefield paths to rename, cleanup, and move files that are uploaded to the site. However, it is not working well with Marketplace. I noticed that renaming with filefield paths is ok for every CCK filefield except the one for Marketplace product files.

Is this something that needs to be configured/modified somewhere?

Thanks,

KH

3dloco, interesting point. I'll take a look at the fielfield paths module and let you know what I learn. Thanks.

keereel, I think we're done here? 3dloco, we can discuss fiefield paths here: http://drupal.org/node/724372.

Hey keereel, I believe the issue pertains to module weight. I had incorrectly set up the weighting system, but corrected it before releasing beta1. Make sure your module weight for site_helper is bigger than UC Marketplace. Let me know how it works for you.

That should work. Did it? As long as MP < helper it should work. Basically the largest weight module will be executed last and will therefore have the last say on how the renaming should be done.