(patch) Finish porting to D7

Hey there,

Yeah, sure :)

[Edited] Well, I'm not sure, since I've no idea when exactly it'll be out I can't say "the day Drupal 7 released" , anyway I think I'll port it to D7 sooner than that.

Erin,

Well, after such a long time! :)

Awesome, something else to play with on D7!

Changing "Style" doesn't change anything - it looks always Blue (Garland Theme, D7 Alpha 5)

Morn - If you go into the superfish.module file, on line 322, there is a space before ' .css'

Remove that space and you'll be able to change the menu styles.

"If you go into the superfish.module file, on line 322, there is a space before ' .css'
Remove that space and you'll be able to change the menu styles."

Is that a "Feature" or a "Bug"? I've been scratching my head on this one trying to figure out why it wasn't working.

Hey Michael,

A bug indeed :) fixed in the coming version though.

Patch, combined with #992470: Superfish-item in Admin menu.

Hi Guys,

I am having some trouble with the superfish menu with Danland Theme 7.x-1.0-RC2 in Drupal 7.0-RC3. The menu is not displaying correctly in the Firefox browser, and I have attached a screen shot. I have not tested in IE.

I was just hoping one of you guys have seen this before, and can offer some tips to resolve it. I have a new install of drupal 7 with only one external module installed, the Superfish.

regards
Graham

Hey Graham,

It is not using this module as far as I know, take a look: http://drupal.org/node/768350#setup-superfish

Thanks Mehrpadin for your reply.

I am definitely using the superfish menu, and I have rechecked all my configuration and that seems OK as well.

Hope you can offer some ideas for me to check. I have added the patch and extra css, but it still not working. Without the patch I can not change style, but that is fixed now.

Graham

Hi Mehrpadin,

Please do not worry about my problem with Superfish and the Danland theme. I am now using a different theme, and the menu system works perfectly.

Graham

@Mehrpadin When is the full drupal 7 version coming up. Its been long since there has been any update. I really like this module (even better than nice menus). As D7 has been released please come up with a full version so that we are more comfortable in using it in production sites.

Hey there,

Hopefully in the next few days, and everyone will be amazed :)

Adding first \ middle\ last classes to menu items is not working.
To fix this change line 498 from:
$firstlast = ($dfirstlast == 1 && $num_items == 1) ? 0 : '';
to
$firstlast = ($dfirstlast == 1 && $num_items == 1) ? 0 : $firstlast;

Zebra striping not working.
Change line 515 from:
$zebra = ($dzebra == 1 && $num_items == 1) ? 0 : '';
to
$zebra = ($dzebra == 1 && $num_items == 1) ? 0 : $zebra;

Following fixex will simply make output more cleaner by not creating empty array items.
Change line 459 from:
$class[] = ($trail && in_array($mlid, $trail)) ? 'active-trail' : '';
to
if ($trail && in_array($mlid, $trail)) $class[] = 'active-trail';
Change line 518 from:
$class[] = ($zebra == 1) ? ($i % 2) ? 'odd' : 'even' : '';
to
if($zebra == 1) $class[] = ($i % 2) ? 'odd' : 'even';
Change line 521 from:
$class[] = ($count == 1) ? 'sf-item-' . $i : '';
to
if ($count == 1) $class[] = 'sf-item-' . $i;

Changes suggested in #18 expressed as a patch.

Patches in #11 and #19 combined.

How's this coming along? I'm anxious to use with D7. Thank you.

@traceelements: I'm currently using the module (with patches in this thread) on my website. So... works for me; your mileage may vary. :)

A newbie question - how do i apply the patche on a hosted Drupal service. I have seen a number of patch modules but they seem to be for Drupal 6.X

Subscribing, though as far as I can see it already works on my test D7 site :)

Seems to work well except that the block will not show for anonymous users. It works great as an admin and I checked the block roles permission settings. I tried with explicitly giving anon permission and with all unchecked(everyone should see it). I'm using alpha 5.

*edit*

It actually works how it should except that it doesn't show on the home page. The home page I am testing with now is a panel. Beware of the checkbox that claims to only disable regions for blocks....it seems as though it is disabling *all* blocks! I will research this further and follow up with the panels team.

Great work guys! Fantastic port although like several other modules the config screen should be moved to admin/config not admin/settings...it ended up my top level navigation which I missed at first. I also notice that other modules have a link to the configuration from the modules page after it's enabled, which is a nicer UX.

Re-rolled patch with suggested change to config page path.

Subscribing

http://drupal.org/node/542202 I found out now that in a module .info file is where you add the configuration link.
example:
configure = admin/config/moduleconfig

hello,I don't know how to use superfish module in drupal 7,and I also can't find any support from the http://drupal.org/documentation /modules/superfish,i really want to got some useful support,can some one help me?

Ni hao :)

The documentation is located here: http://drupal.org/node/754652 , and you're always welcome to ask your questions.

xiexie,it is worthy to watch,i have known how to use it,thank you very much!

Re-rolled; must have been looking at 6.x when I made the last patch.

I can confirm the patch works great and adds first, last and middle classes as well as even/odd classes.
Great idea also to put the settings into a proper place in the config section.

There is an error when patching the .info though: it tries to replace the configure settings in line 6, but in the latest version of the module they are found at line 9. So one more reroll to get a RTBC from me :)

Patch is against git "master" branch, which should be identical to CVS "HEAD". This should be easier for the maintainer to apply. The "release" version of the .info file is auto-generated by the release system and different from the version checked in by the maintainer.

Thanks for this! Same comment as eigentor. The configure settings are on line 9 if I pull via:
cvs -z9 -d:pserver:anonymous:anonymous@cvs.drupal.org:/cvs/drupal-contrib checkout -r DRUPAL-7--1 contributions/modules/superfish

Replacing DRUPAL-7--1 with HEAD pulls a 6.x version. I guess I just don't understand cvs that well.

@35 - yeah thats just CVS and one way you can run your repo, probably the D7 version is developed in the branch and not in head, and will need to be merged back to head before cutting a D8 branch (or is that master...). I have done it like this also in some projects.

Re-rolled with "cvs diff" against a DRUPAL-7--1 checkout as per #35.

@youyoums -- don't assign yourself to an issue if you're not going to fix it.

Could someone post a tar of the active dev version? Or do I need to "Browse CVS repository" and download every file individually?

Hey Anna,

Dev version is not available there, but soon we'll have a beta.

Re-rolled after the Great Git Migration.

Bump and priority bump.

Subscribe/bump

--- superfish.module.orig	2011-03-17 15:55:11.000000000 +0100
+++ superfish.module	2011-03-17 15:55:16.000000000 +0100
@@ -318,7 +318,7 @@
   $pathclass = ($type == 'navbar') ? "\n pathClass: 'active-trail'," : '';
 
   if ($style != 'default') {
-    drupal_add_css(drupal_get_path('module', 'superfish') . '/css/extra/' . $style . ' .css');
+    drupal_add_css(drupal_get_path('module', 'superfish') . '/css/extra/' . $style . '.css');
   }
 
   $animation = ($slide == 'true') ? "animation: {opacity:'show',height:'show'}," : '';

Re-rolled. Includes fix in #45.

One patch is against 7.x-1.x and the other is against 7.x-1.8-alpha5

This seems to be a long long wait for next version of superfish.

so long waiting

subscribe

I really think we can RTBC this patch.

+1 subscribe

Agree with pillarsdotnet. I've reviewed the patch code pretty thoroughly and have been using it without issues for a month.

Much of this patch has been applied already. Opening up a new issue for the rest, and for other errors introduced in the meanwhile.