CVS edit link for ryanaghdam

For the past year and half, I have used Drupal extensively in my employment at Harvard University and at Lantheus Medical Imaging, a local pharmaceutical company. In this time, I have utilized Drupal to develop some truly wonderful websites that could not have been completed without the tool.

At Harvard University, I proposed and implemented the use of Drupal on the following websites: http://reai.harvard.edu/ http://english.fas.harvard.edu/ and http://alumni.harvard.edu/.

My work at Lantheus includes the proposal and implementation of Drupal on the corporate intranet site. I am particularly proud that I was able to defend Drupal to managers that think Open Source software is evil, and that Firefox is a malicious software.

I have begun to learn module development, and have produced my first Drupal module. It is a block that provides a link to post the current node to Google Buzz. This initial version is simple--features can (and if the this application is accepted, will) be added in the future. A demonstration and download link can be found here: http://buzz-demo.ryanaghdam.com/

If an account is granted, I plan to develop additional themes for submission.

Thank you for your time. If there is any further information that I can provide, please do not hesitate to email me (ryan.aghdam@gmail.com).

CommentFileSizeAuthor
#1 buzzthis-0.1.tar_.gz1.94 KBryanaghdam

Comments

ryanaghdam’s picture

ryanaghdam commented
StatusFileSize
new buzzthis-0.1.tar_.gz1.94 KB

Attaching the module.

ryanaghdam’s picture

ryanaghdam commented
Status: Postponed (maintainer needs more info) » Needs review
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Issue tags: +Module review

Hello, and thanks for applying for a CVS account. I am adding the review tags, and somebody will review your code.

As per Apply for contributions CVS access, the description of the proposed module should be expanded; this would help in speeding up the review of the module, and avoid the reviewer points out there is already a similar module in Drupal.org CVS.

ryanaghdam’s picture

ryanaghdam commented

Hi--

The module creates a block that will allow visitors to post a link to the current page on Google Buzz. The link will bring the user to the submit page for Google Reader (see note below) that contains a post that contains the current node's teaser and a link to it. When the form is submitted, the user is returned to the node that was being viewed.

Note: The only current method of posting to Google Buzz with an external application/Link is through Google Reader. Google Buzz shares links from Google Reader.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs review » Needs work
  1. The first argument of t() must be a literal string, not a dynamic value. 
  2. function buzzthis_snippet() {
  if(arg(0) == 'node' && is_numeric(arg(1))) {
    $node = node_load(arg(1));
    $teaser = node_view($node, TRUE);
    $teaser = eregi_replace("<h2>.*<\/h2>", "", $teaser);
    $teaser = strip_tags($teaser, "<a><p>");
    $teaser = eregi_replace("\n", "", $teaser);
    $teaser = check_plain($teaser);
    return $teaser;
  }
}

    The code should not show nodes for which the user doesn't have access. This is considered a security issue. 

  3. function buzzthis_showIcon() {
  return "<img src=\"" . 
    buzzthis_iconPath() . 
    "\" alt=\"Buzz This!\" />";
}

    There is a theme function that can be used to theme an image.

  4. The block implemented by the proposed module can be created using a custom block. There is no need to create a block for this purpose.
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs work » Closed (won't fix)

There have not been replies in the past week. I am marking this application as won't fix.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Component: Miscellaneous » new project application
Issue summary: View changes

Please read the following links as this is very important information about CVS applications.

Drupal.org has moved from CVS to Git! This is a very significant change for the Drupal community and for these applications. Please read Migrating from CVS Applications to (Git) Full Project Applications and Applying for permission to opt into security advisory coverage on how this affects and benefits you and the application process. In short, every user has now the permissions necessary to create new projects, but they need to apply for opt into security advisory coverage. Without applying, the projects will have a warning on projects that says:

This project is not covered by Drupal’s security advisory policy.