Check if imagecache module is available

Posted by NigelCunningham on February 14, 2010 at 10:44am

4 followers

Issue Summary

I installed the module without having imagecache installed and got blank pages with the following in logs:

/public_html/sites/all/modules/filefield_styles/filefield_styles.module(104) : Fatal error - Call to undefined function imagecache_presets()

I think you need to add an additional dependency.

Regards,

Nigel

Posted by eoneillPPH on May 17, 2010 at 3:06pm

And ImageCache, as we should all know, requires ImageAPI. So that's TWO dependencies missing from the module page here.

Had a very panic-y client when we turned on Filefield Styles!

Posted by roball on July 10, 2010 at 6:25am

Title:	Also depends on imagecache for imagecache_presets.	» Make module dependent of imagecache
Priority:	normal	» critical

Posted by jwilson3 on July 15, 2010 at 12:06am

The code uses a call to module_exists('imagecache') elsewhere which makes me wonder if the module really should be dependent upon imagecache?

Eg, What if you don't want this module for any image files, but for a PDF / DOC / RTF handler?

I was able to avoid this error upon installation by wrapping the foreach at line 107 in an if module_exists.

Attachment	Size
713970.patch	1018 bytes

Posted by jwilson3 on July 15, 2010 at 12:14am

Status:

active

» needs review

updating status.

priority = critical should be left as is because the module is "broken" out of the box if you don't have/want to install imagecache.

someone else can update the title to reflect my proposal in #3 if they deem it necessary...

Posted by roball on July 15, 2010 at 12:24am

Title:

Make module dependent of imagecache

» Check if imagecache module is available