Install code is flawed (and won't insert some countries in the db on PostgreSQL/MySQL)

I came across the same problem on Postgres.

I've crafted a patch to use Schema API's drupal_write_record() to insert into the table instead of constructing the query manually. I've also changed the schema def to make iso3 properly nullable.

Patch attached.

@neilnz: your patch contains a slight bug in line 259 was making a couple of the tests fail. I have corrected and committed to CVS (http://drupal.org/cvs?commit=345512)

In countries_api_csv_import_countries()

'iso3' => ($row[3] !== 'NULL') ? $row[0] : NULL,

Should have read:

'iso3' => ($row[3] !== 'NULL') ? $row[3] : NULL,

Reopening this.

The code with drupal_write_record() does not work during fresh install of the module. This is because drupal_write_record() only works for schemas defined in already fully installed modules. Since we have still not returned from countries_api_install() function at that point, drupal_write_record() will silently fail and no data gets inserted into the table.

I ran into this or a similar bug on enabling this module with postgres. 10+ lines like this:

                                                                                         [error]
query: INSERT INTO countries_api_countries (iso2, name, printable_name, iso3,numcode)
         VALUES('HM', 'HEARD ISLAND AND MCDONALD ISLANDS',
'Heard Island and Mcdonald Islands', 'NULL', NULL) in
/www/drupal/sites/all/modules/countries_api/countries_api.module on line 265.
pg_query(): Query failed: ERROR:  value too long for type character(3) in                [warning]
/www/drupal/includes/database.pgsql.inc on line 139.

I have MySQL running, and the install-script doesn't work for me, either, because of this commited patch.
I think the .csv file should work with empty columns, too, instead of using NULL-values.
I made the following 'patch' in countries_api_csv_import_countries().

 while (($row = fgetcsv($handle, 1024, ",")) !== FALSE) {
    //Create row variables
    $record = array(
      'iso2' => $row[0],
      'name' => $row[1],
      'printable_name' => $row[2],
      'iso3'           => ($row[3] !== 'NULL') ? $row[3] : NULL,
-      'numcode' => ($row[4]) ? $row[4] : NULL
+      'numcode'        => ($row[4] !== 'NULL') ? $row[4] : NULL,
    );
    if ($index > $offset) {
+//drupal_write_record() does not work while installing modules. Even better would be using db-insert().
-     drupal_write_record('countries_api_countries', $record);
+      db_query(
+        "INSERT INTO {countries_api_countries} 
+            (iso2, name, printable_name, iso3, numcode) 
+             VALUES('%s', '%s', '%s', '%s', '%s')",
+//             $iso2, $name, $printable_name, $iso3, $numcode
+             $record[iso2], $record[name], $record[printable_name], $record[iso3], $record[numcode]
+      );

This should be resolved in git now.
Thanks.