The node_type_get_types() function isshould be immutable. The test enviroment is attached.

CommentFileSizeAuthor
#2 node-corrected.patch1.36 KBnevergone
#1 node-corrected.patch1.39 KBnevergone
node-test.patch943 bytesnevergone

Comments

nevergone’s picture

nevergone
Primary language Hungarian
commented
StatusFileSize
new node-corrected.patch1.39 KB
nevergone’s picture

nevergone
Primary language Hungarian
commented
Status: Active » Needs review
StatusFileSize
new node-corrected.patch1.36 KB

corrected patch (permission error)

chx’s picture

chx commented
Title: node_type_get_types() is immutable » node_type_get_types() should be immutable
Status: Needs review » Reviewed & tested by the community
dries’s picture

dries commented

While technically correct, I wonder if this needs fixing. We probably return a lot of variables that probably should be made immutable. That said, I'm not opposed to this patch but it might warrant some extra discussion.

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Closed (duplicate)

Agreed. As far as I know, every cloned variable leads to double memory consumption, also this is a duplicate of #154859: Document that cached entity objects are not necessarily cloned any more.

nevergone’s picture

nevergone
Primary language Hungarian
commented

simple test environment, create 5 node:

for ($i = 0; $i < 5; $i++) {
  $node = node_type_get_type('article');
  $node->language = LANGUAGE_NONE;
  $node->title = $i. '. title';
  $node->body[LANGUAGE_NONE][0]['format'] = 1; // plain text
  $node->body[LANGUAGE_NONE][0]['value'] = $i. '. body';
  $node = node_submit($node);
  node_save($node);
  unset($node);
}