I have had problems with the menu not showing up. I checked out the code and saw that the code stops executing at subMenu = dynamic_persistent_menu_get_sub_menu(overMenu) because overMenu is not set. Perhaps it should be set upfront? I see that there is a javascript setting being passed by the module but not being used.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | dynamic_persistent_menu_add_comments.patch | 2.11 KB | zyxware |
| #2 | dynamic_persistent_menu_fix_indentation.patch | 2.71 KB | zyxware |
| #1 | dynamic_persistent_menu_fix_over_menu.patch | 883 bytes | zyxware |
Comments
Comment #1
zyxware commentedHere is a patch that will fix the issue. I have also changed the way the onload function is registered
Comment #2
zyxware commentedI have indented the code and am submitting the corresponding patch. The patch is taken against the state after applying the previous patch.
Comment #3
zyxware commentedI have commented the javascript code and am submitting the corresponding patch. The patch is taken against the state after applying the previous patch.
Comment #4
yrocq commentedGood point. However, I can't apply the patches. It seems that there are extra spaces at the beginning of some lines.
Comment #5
zyxware commentedPerhaps you could try out the combined patch posted at #728938: Full support for multiple menus. That patch is created against the latest dev version.
Comment #6
zyxware commentedDid you try the patch versus the latest 2.x release?
Comment #7
yrocq commentedI don't understand. Is it a patch for 1.x or 2.x version ? This issue is about 1.x.
Comment #8
yrocq commentedI applied the patch by hand in CVS and created a new stable release, thanks !
Discussions about version 1.2 should take place in #728938: Full support for multiple menus.
Comment #9
yrocq commented