Download & Extend

Issues with javascript - dynamic persistent menu not showing up

Project:Dynamic Persistent Menu
Version:6.x-1.x-dev
Component:Code
Category:bug report
Priority:normal
Assigned:yrocq
Status:closed (fixed)

Issue Summary

I have had problems with the menu not showing up. I checked out the code and saw that the code stops executing at subMenu = dynamic_persistent_menu_get_sub_menu(overMenu) because overMenu is not set. Perhaps it should be set upfront? I see that there is a javascript setting being passed by the module but not being used.

Comments

#1

Here is a patch that will fix the issue. I have also changed the way the onload function is registered

AttachmentSize
dynamic_persistent_menu_fix_over_menu.patch 883 bytes

#2

I have indented the code and am submitting the corresponding patch. The patch is taken against the state after applying the previous patch.

AttachmentSize
dynamic_persistent_menu_fix_indentation.patch 2.71 KB

#3

I have commented the javascript code and am submitting the corresponding patch. The patch is taken against the state after applying the previous patch.

AttachmentSize
dynamic_persistent_menu_add_comments.patch 2.11 KB

#4

Status:active» needs work

Good point. However, I can't apply the patches. It seems that there are extra spaces at the beginning of some lines.

#5

Perhaps you could try out the combined patch posted at #728938: Full support for multiple menus. That patch is created against the latest dev version.

#6

Status:needs work» active

Did you try the patch versus the latest 2.x release?

#7

I don't understand. Is it a patch for 1.x or 2.x version ? This issue is about 1.x.

#8

Assigned to:Anonymous» yrocq

I applied the patch by hand in CVS and created a new stable release, thanks !

Discussions about version 1.2 should take place in #728938: Full support for multiple menus.

#9

Status:active» fixed

#10

Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

nobody click here