Since PHP 5.3 the "revisions" tab of a node is broken, see http://drupal.org/node/639320 for more information and the original bug report. Unfortunately, fixing this issue also requires a minor patch for content.diff.inc of CCK. This patch is attached to this bug report. Hopefully it can be patched soon!

CommentFileSizeAuthor
#2 cck_diff.patch108 bytesRobbert

Comments

karens’s picture

karens commented
Status: Needs review » Postponed (maintainer needs more info)

There is no patch attached and the Diff module has not been altered with your proposed patch either. We can't really do anything here until Diff is patched so we can be sure how they will handle the situation. Then we will need a patch for CCK that works with the Diff changes. And we need someone to confirm that the code works in PHP4 with whatever changes are proposed.

Robbert’s picture

Robbert commented
StatusFileSize
new cck_diff.patch108 bytes

Oops, forgot to attach my patch.

My patch doesn't depend on my proposed patch for Diff, it only removes two useless reference symbols. The objects passed to the function aren't modified, so it should work independently and shouldn't have any consequences for PHP4.

dooug’s picture

dooug commented

I also implemented the patch in comment #2. Works fine, and I agree it shouldn't affect the PHP 4 compatibility.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Postponed (maintainer needs more info) » Reviewed & tested by the community

I can confirm the change, the hook is called with module_invoke_all() so the arguments can't be by reference.

Encarte’s picture

Encarte commented

subscribe

thekevinday’s picture

thekevinday commented
Issue tags: +PHP, +PHP 5.3, +call by reference

I can confirm this issue and this fix as well.

ShutterFreak’s picture

ShutterFreak commented

What is the status of this patch?

karens’s picture

karens commented
Status: Reviewed & tested by the community » Fixed

OK, committed. Agreed that it won't affect PHP4 since we don't modify the nodes.

Status: Fixed » Closed (fixed)
Issue tags: -PHP, -PHP 5.3, -call by reference

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +, +PHP 5.3, +call by reference

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.