Further CSS classes for table and grid views

I like to move logic from the template into preprocess, but sadly there are some minor things

+    foreach ($vars['rows'][0] as $fields => $field) {

I don't like $fields as variable here, its $field_id, or something similar.

+    if (count($vars['rows'][0]) == 1) {
+      reset($vars['rows'][0]);
+      $vars['col_classes'][key($vars['rows'][0])][] = 'views-col-single';
+    }
+    else {
+      reset($vars['rows'][0]);
+      $vars['col_classes'][key($vars['rows'][0])][] = 'views-col-first';
+      end($vars['rows'][0]);
+      $vars['col_classes'][key($vars['rows'][0])][] = 'views-col-last';
+    }

It would be better for people if you have inline comments where you describe what reset key and end does here.

This is a great and use full patch. Please commit it!

Related issue: http://drupal.org/node/682888

Can you please have a look where the implode should be done? in template file or preprocess

<tr class="<?php print implode(' ', $row_classes[$count]); ?>">

Sorry for this.

As you did show me on IRC the only option to avoid this in D6 would be to do some special hook_theme implementation like this ZEN theme is doing. So I'd still say go for it. I will try to catch earl on IRC to talk about this. Hope I find some time. Otherwise maybe he stumbles about this issue and likes it ;)

Sorry but

patch -p0 < views-grid-and-table-v2.patch
patching file theme/theme.inc
Hunk #2 succeeded at 449 (offset 1 line).
patching file theme/views-view-grid.tpl.php
Hunk #1 succeeded at 2 with fuzz 1.
Hunk #2 FAILED at 20.
1 out of 2 hunks FAILED -- saving rejects to file theme/views-view-grid.tpl.php.rej
patching file theme/views-view-table.tpl.php

Update status

No updated to patch in over 3 months.