Error handling for invalid path
mindless - June 29, 2006 - 18:14
| Project: | Gallery |
| Version: | 5.x-2.x-dev |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed |
Description
Code in _gallery_init treats ERROR_MISSING_OBJECT to mean the user is not mapped into G2.. however, the same error is returned when URL rewrite is in use and an invalid path is given. Not sure if this is the best resolution, but the attached patch at least gets the right error into drupal watchdog for bad path.
| Attachment | Size |
|---|---|
| gallery_init_patch.txt | 2.79 KB |
#1
A much simpler solution. Don't attempt to create a G2 user for anonymous. This causes the Gallery module to return the standard G2 'path not found' error.
#2
what if a non-guest accesses an invalid path?
#3
Committed a modified version of this. Still does not work for logged in users, but certainly helps.
#4
As in the 5--2 branch the user sync does no longer happen in gallery_init(), this problem should be fixed. Invalid paths are handled in gallery_handle_request() now, this works for logged in users as well. (An admin will still see ERROR_MISSING_OBJECT, but its catched nicely and remains invisible for 'normal' users.)
#5