Wrong Jquery.ui css path (for jquery 1.6)

Not sure is this related.

When I tested dialog_comments, on pages with comments in any version of IE browser, It looks like css files do not work, even in garland theme (I have naked theme, without css styles). In all another browsers (firefox, mozilla) it works fine, but not in IE.

And problem exactly with this string
drupal_add_css(JQUERY_UI_PATH .'/themes/base/ui.all.css');

if I remove it than page again has its theme style. (I tried to change 'base' for 'default' - no result)

UPD (closed):
Looks like I had problem with theme rebuild

I can confirm this issue. After changing:

drupal_add_css(JQUERY_UI_PATH .'/themes/base/ui.all.css');

to

drupal_add_css(JQUERY_UI_PATH .'/themes/default/ui.all.css');

the dialog interface changed, and looks as expected.

Elvin.

confirming and moving to critical. Thanks antoniofcano

on further review "/themes/base/ui.all.css" is proper for jquery_ui 1.7 (which is the modules intended jquery_ui release).

"/themes/default/ui.all.css" is proper for 1.6, but then a few other things are slightly broken in 1.6, so I suppose use 1.7 where possible.

The 1.7 dependence should probably be documented in the readme.txt

The 1.7 dependence should probably be documented in the readme.txt

This does seem to be stated in the readme.

Using jQuery 1.6 (unsupported)
--------------------------------------------------------------------------------
This module has been designed to work with jQuery UI 1.7 and therefore requires
the jQuery Update module along with jQuery UI module. If you would prefer to
use it with jQuery 1.6, simply remove the dependency line from the dialog.info
file. Though there are reports that it works well enough with 1.6, this is
definitely UNSUPPORTED functionality. Please only file an issue for this if you
are submitting a patch that would make it work for both versions.

Let's be a little nicer with this, and do it automatically...

Ironically (despite the dependency) jQuery UI 1.7 doesn't work with Dialog API.

Committed patch from #7 with a change to use version_compare().

Thanks Amitaibu

Find

  // Get the correct CSS path based on jQuery UI version.
  $version_16 = version_compare(jquery_ui_get_version(), '1.7.0', '<');
  $css_path = $version_16 ? 'default' : 'base';
  drupal_add_css(JQUERY_UI_PATH .'/themes/'. $css_path .'/ui.all.css');

Change to:

  // Get the correct CSS path based on jQuery UI version.
  $version_16 = version_compare(jquery_ui_get_version(), '1.7.3', '<');

	$css_path = jquery_ui_get_version() == 1.6 ? 'default' : 'base';
	drupal_add_css(drupal_get_path('module', 'jquery_ui').'/jquery.ui/themes/start/ui.all.css');