Hi,

according to issue http://drupal.org/node/323101 the title attributes in hook_menu() sould not be passed through t(), since it causes translation problems (the title is passed through t() again later on).

Beside this, I propose to shift the language spefic title components (called via _uc_pnag_name()) to the page content (e.g. the form). Menu framework seems not to support any variables in page titels at the moment.

If not, a multilangual usage of this modul is quite difficult.

Regards,
Thomas

Comments

pieterdc’s picture

pieterdc
Primary language Dutch
Location Ghent
commented

+1 for this request

pieterdc’s picture

pieterdc
Primary language Dutch
Location Ghent
commented

Tip:

In function _uc_pnag_description()
Replace return _uc_pnag_logo() .'<div>'. $desc[$lng] .'</div>';
by return _uc_pnag_logo() .'<div>'. t($desc[$lng]) .'</div>';

Doing so, you'll be able to use Drupal's standard translating features to formulate an alternative description (text).

jurgenhaas’s picture

jurgenhaas
he/him
Primary language German
Location Gottmadingen
commented
Status: Needs work » Needs review

I have just submitted a new dev release with the t() calls removed from hook_menu() and I included the new property 'title arguments' as well for the parameters.

What I haven't done is sending the descriptions through t() because Payment Network AG insisted in having the descriptions "as-is" in the module.

jurgenhaas’s picture

jurgenhaas
he/him
Primary language German
Location Gottmadingen
commented
Status: Needs review » Fixed

Due to no response

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.