4.7.2

Updated to CVS so as to take advantage of previous fix for new vocabs.

Update ran fine and reported no problems.

Nice to see cloning and my new vocabs.

But when I returned to the site a few mins later, got this :-

Fatal error: Only variables can be passed by reference in /mounted-storage/home20a/sub001/sc19995-IHES/www/drupal/modules/insert_view/insert_view.module on line 86

Comments

merlinofchaos’s picture

merlinofchaos commented
Project: Views (for Drupal 7) » Insert View
Version: 6.x-2.x-dev » 4.7.x-1.x-dev

This appears to be an insert_view issue?

iandickson’s picture

iandickson commented

if you're asking me, I don't know enough to comment, except to note that the error line suggests so. Sorry I can't be of more help.

version34’s picture

version34 commented
Status: Active » Reviewed & tested by the community

Hi,

I have no clue of Drupal and PHP etc. but it seems like it is easy to fix like this:
replace line 83 by
$replace = views_build_view('embed', $view, $view_args, FALSE, $limit);

and line 86 by
$replace = views_build_view('embed', $view, $view_args, FALSE, NULL);

(note the difference on the term "$view" in the middle of the function call). (Is there a reason why you did this twice in your previous code, you actually read out $view already in line 71?)

Any problems occuring out of this?

Hope this fixes the problem....

/version34

RayZ’s picture

RayZ commented
Status: Reviewed & tested by the community » Fixed

Appears this was fixed in cvs: http://drupal.org/cvs?commit=35558

@Eaton: Do you also need to move the DRUPAL-4-7 tag? A cvs checkout with -r DRUPAL-4-7 doesn't seem to include this fix, and I don't see a separate 4.7 branch.

eaton’s picture

eaton commented

RayZ -- yes, that should fix the issue. I haven't done a lot of testing with it though, as I'm juggling 4th of July activities, and didn't want to make the checkin the 'official' 4.7 version until I knew it didn't break anything else.

If it's woring for those who've experienced the problem, I can mobe the 4.7 branch right now.

RayZ’s picture

RayZ commented

Ah ... no problem if it was intentional. I assumed it was an oversight.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)