I've noticed that Views (latest stable version) lost its AJAX behaviour (all displays are opened below each other). I started disabling various modules until the problem disappeared with disabling all Modal Frame modules.

Then I just switched on Modal Frame API, and Views AJAX still worked.

Then I added Modal Frame Blocks - and AJAX in Views was broken.

It may be happening with other contribs from this package; I did not test.

Let me know if you need more details and what.

CommentFileSizeAuthor
#6 modal_blocks.PNG9.03 KBvacilando

Comments

abulte’s picture

abulte commented

I can confirm this bug report.

I can also say that the blocks submodule is responsible, for example cck submodule works fine.

Drupal version : 6.15
Views version : 6.x-2.8

markus_petrux’s picture

markus_petrux commented
Priority: Critical » Normal
Status: Active » Postponed (maintainer needs more info)

I think this may happen depending on the versions of jQuery/jQuery UI. IIRC, it works ok with jQuery 1.3.x and jQuery UI 1.7.x.

Can anyone confirm this?

vacilando’s picture

vacilando commented

@markus_petrux - I use

* http://drupal.org/project/jquery_ui 6.x-1.3 (and my status page says: "jQuery UI 1.6")

* About jQuery - I use jQuery Update 6.x-1.1 (status pase says "1.2.6"). I have never started using 6.x-2.x because it has never come out of dev version. I recall once trying the dev version but it created all sorts of problems with modules and I reverted to 6.x-1.1. Are you saying Modal Frame requires 6.x-2.x-dev -- or are you saying it works for you satisfactorily enough these days?

Let me know if I can test something to help.

markus_petrux’s picture

markus_petrux commented

jquery_update 6.x-1.1 comes with jQuery 1.2.6, which is the same version provided by Drupal 6 core itself, so there's no need for that, I think.

jquery_update 6.x-2.x-dev updates Drupal 6 to jQuery 1.3.2, a few issues have been fixed recently, and almost all modules have been fixed to work properly with that version of jQuery, so I think it would be a good thing to try again with jquery_update 6.x-2.x-dev. See #358082: jQuery 1.3 in Drupal 6.x

The problem with jQuery 1.2.x is that it seems to be frozen, it does not get fixes, and it is pretty old these days where jQuery is at 1.4.x. Note though that jQuery 1.4 has not been properly tested under Drupal contexts, meaning jquery_update module is not ready yet for that jump. See #685060: Get ready for 1.4

Upgrading to jQuery 1.3.x allows to jump jQuery UI to 1.7.x which is a step forward in the right direction too. Both versions are living in the wild enough time consider them stable enough, from the point of view of developers and end users, and this bundle works better with today browsers, less memory leaks, less bugs, more features, etc.

I coded all the Modal Frame stuff working with jQuery 1.3.x and jQuery UI 1.7.x. The project page and docs say it also supports jQuery 1.2.6 and jQuery UI 1.6.x, but that is just because someone opened an issue about that, and I just tested it a little, confirmed, but I have never tested it again, so it could happen that those legacy versions of jQuery stuff do not work properly these days with other modules and/or libraries.

I would even says that if by any chance, the result of this issue is that things works with jQuery 1.3.x and jQuery UI 1.7.x, then I will simply deprecate support for jQuery 1.2.6 / jQuery UI 1.6.x.

vacilando’s picture

vacilando commented

All right, so I did upgrade, but the experience has been rather disastrous:

Upgraded to jquery_update 6.x-2.x-dev (deleted the previous one on server first, then uploaded the dev), ran /update.php, enabled Modal Frames again. Cleared all caches in Drupal, and in FF.

Edited a view -- again it is non-AJAXy!!

Went to the blocks page (/admin/build/block) -- it contains dozens of errors like this:
# warning: Attempt to assign property of non-object in /MYSITEPATH/content/includes/common.inc on line 3428.
# user warning: Duplicate entry '0' for key 2 query: INSERT INTO blocks () VALUES () in /MYSITEPATH/content/includes/common.inc on line 3477.
Other pages did not seem to contain error messages, just the blocks page.

Modal Frame on blocks did not work at all - what should have been in a frame opened in a page, so I had to click the back browser button to get back to the main page.

Lightbox2 (6.x-1.9) stopped functioning -- images opened alone on a page rather than in an overlay. Upgraded Lightbox2 to dev version, ran /update.php, cleared caches -- OK, that issue got resolved; the dev version of Lightbox2 works with jquery_update 6.x-2.x-dev

Went back to the blocks page, reloaded. The warnings are still there. But when I click on "configure", there is a visible attempt of Modal Frame to open up. Unfortunately, it does not work - the frame stays small -- see attached image. Precisely the same small non-functional frame appears when trying to configure fields for CCK (/admin/content/node-type/page/fields)

Views editor still not AJAXy.

Switched off all Modal Frame modules except for Modal Frame API, cleared caches.
Reloaded the blocks page - the errors are still there.
But the Views editor is AJAXy, OK.

Summary -- upgrade to jquery_update 6.x-2.x-dev meant
* unexpected need for upgrading Lightbox2 to an unstable version
* strange errors on the blocks page
* Modal Frame even less functional than under jquery_update 6.x-1.1
* Views editor AJAX functionality with Modal Frame on did not improve

--

Note: I have NOT upgraded jQuery UI to 1.7.x as you mention, I am still at jQuery UI 1.6. The reason is that even the dev version of jQuery UI offers 1.6. Upgrade may be possible but it's a hack that we cannot expect most people do.
Do you think my above problems can be caused by not having jQuery UI 1.7?

vacilando’s picture

vacilando commented
StatusFileSize
new modal_blocks.PNG9.03 KB

Forgot the attachment... here it is.

myktra’s picture

myktra commented

I can confirm that after using jquery_update-6.x-2.x-dev to get jQuery 1.3, receiving the same symptoms with ModalFrame (in my case it was a dependency of Node Relationships).

Upgrading jquery_ui's jQuery UI from 1.6.x to 1.7.3 cleared up the issue. But yes, I have had to go with jquery_update-6.x-2.x-dev to get jQuery 1.3 and it would be great to be using a stable "2.0" version of this.

markus_petrux’s picture

markus_petrux commented

@myktra: "I have had to go with jquery_update-6.x-2.x-dev to get jQuery 1.3 and it would be great to be using a stable "2.0" version of this"

Thanks for the information. Please, see #723410: Create stable 2.0 release for jQuery Update

@vacilando: I think I will officially state in the project page of Modal Frame API that jQuery 1.2.x is not supported anymore. Too much issues causing loss of time to all of us.

markus_petrux’s picture

markus_petrux commented
Status: Postponed (maintainer needs more info) » Closed (fixed)

- #798618: Deprecate support for jQuery UI library 1.6.x