I think we should remove support for user contact form paths (e.g. user/uid/contact). There are infinite number of paths that could lie under user/uid/* (or node/nid/*, etc) that the Sub-path URL alias module is much better suited for those types of paths.

Especially if we want to generalize Pathauto to work on 'entities', a user's contact form is *not* an entity, while the user account itself is.

CommentFileSizeAuthor
#8 717386-pathauto-unsupport-subpaths-D7.patch4.55 KBdave reid

Comments

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented

Seriously good idea.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Assigned: Unassigned » dave reid
dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented

Can we pull the trigger on this? It's going to make all the other work with coverting pathauto to use entity information way easier to handle since we won't have to work around these fringe patterns anymore.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented

I think so.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented

Ok great. I'll clean up some of the existing issues then be able to work on this.

Freso’s picture

Freso commented

Dave, I'd like to give this a go once I'm back from ROD (around Thursday). if you won't mind hacking on some of your other projects? :p I need to get back into the Patauto code after all your changes. ;)

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented

Freso, do you still want to work on this? I'd love to officially move forward with this. Although if we want to postpone this until a 7.x-2.x that's understandable too.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Active » Needs review
StatusFileSize
new 717386-pathauto-unsupport-subpaths-D7.patch4.55 KB

Patch for review. Can I get a quick +1 from the crowd? This will help make some other patches moving forward easier as we don't have to support as much code.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented

Indeed, +1.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Needs review » Fixed

Bang! They're gone!

http://drupal.org/cvs?commit=396202
http://drupal.org/cvs?commit=396204

Also forgot to remove the variables, so there were follow-up commits:
http://drupal.org/cvs?commit=396208
http://drupal.org/cvs?commit=396210

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.