I've started a D7 upgrade of this module. This is probably a bit earlier than I'd submit a patch, but chx mentioned in IRC that they had planned to do an upgrade on this next week, so I'm posting what I have so far now.

So far, this is just for twitter.module, and I haven't touched the sub modules (which are largely unneeded by me, but I might put some time into them anyway). Also, this is my first shot at a d7 upgrade so things might be a bit sloppy. Any criticisms welcomed.

At this point I've worked through all of the 6.x => 7.x upgrade guide, at least at a superficial level. It's possible I missed a thing or two (the list is, uhh, comprehensive).

What Works:

  • Enabling the module (yay!)
  • The admin settings page
  • Adding your first account from your user page
  • Importing statuses on cron
  • Views integration. well, at least as well as the 7.x branch of views works. I think. Basic listing works, but the default view doesn't work unless you remove the argument.
  • The user/%/tweets (mostly), I get some warnings from filter.module

Before I say what doesn't work, let me disclaim that I've never actually used this module for 6.x, and my testing is not comprehensive. There just may be more than this that doesn't work yet.

  • The user/%uid/edit/twitter page after accounts are added. It kinda works, but the table view is broken. I call drupal_render_children on both forms, which is very ugly. If I don't call drupal_render_children, I can't make the page load. If I just call drupal_render on each form, I also can't make the page load. I'm not sure what to think about this one et, and haven't had time to properly debug it.
     if (!empty($twitter_accounts)) {
        $output .= drupal_render_children(drupal_get_form('twitter_account_list_form', $twitter_accounts));
      }
      $output .= drupal_render_children(drupal_get_form('twitter_account_form', $account));
    

Anyway, like I said, earlier than I would normally post progress, but it looks like others might be interested in collaborating on this, so I thought it worth posting progress.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

beeradb’s picture

Status: Active » Needs work
FileSize
39.43 KB

where'd the patch go :(

beeradb’s picture

Status: Needs work » Active
FileSize
39.34 KB

Cleanup of some sloppy code.

  • Implemented hook_user_categories()
  • reverted to using %user_categories autoloader
  • renamed hook_admin_paths -> twitter_admin_paths as it should be
  • and a couple small coding standards cleanups.
beeradb’s picture

Status: Active » Needs work
FileSize
44.62 KB
  • Updated the filter system. Missed this in the module the first time through. I created wrapper functions for each of the filter types, as calling filter callbacks with parameters does not appear to be supported anymore.
  • twitter_actions.module now installs, can be added to triggers, and allows configuration. I have not tried actually posting with it, though I assume it works. Will test that before posting the next patch

All I know of that needs to be done:

  • upgrade twitter_post.module.
  • fix the account forms under the user edit page. They are pretty broken once you add accounts.
  • upgrade twitter_signin.module. This can't be done until oath is upgraded, and there is no sign of work on that front
beeradb’s picture

Status: Needs work » Postponed

After a conversation in IRC with walkah today I'm not sure how much use there is for what has been done here so far. Walkah indicated that he was hoping to finish up everything listed in todo.txt from the 3.x branch before porting this to 7.

steinmb’s picture

Status: Postponed » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.