Closed (fixed)
Project:
PayPal Buttons for Ubercart
Version:
6.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
18 Feb 2010 at 18:35 UTC
Updated:
18 Sep 2010 at 21:40 UTC
Jump to comment: Most recent file
Comments
Comment #1
abowers commentedI've looked into this a bit, and it looks like this module is sending 'retry' instead of 'sra' as PayPal expects, see https://cms.paypal.com/us/cgi-bin/?cmd=_render-content&content_ID=develo....
Maybe they've changed the api. In any case, I ended up making some changes that allow 'sra' to be sent on the url, however, it doesn't seem to turn off when you disable the retry setting in the product feature. This is fine for our needs, but probably not a good idea in general! I've attached the patch so that someone with more knowledge can take a look. I was curious if line #713 is incorrect, and if 'retry' should be changed to 'sra' also in the $form_state. Not sure if it is an issue in my code changes or in my testing practices!
Comment #2
arithmetric commentedThanks for reporting this. I noticed in the PayPal documentation that the default setting for the "reattempt payment request on failure" option is enabled/on. So I modified your change slightly to show that this is enabled by default and ensure that the setting can be disabled. This fix will be included in the next development and stable release.