Hi,
When I insert a popup filter (ie [popup ...]) inside a text (block body), the part of text ABOVE this popup filter is wrapped in

tags. So a popup filter can't be really inline.
Is there a solution?
Thanks in advance!

Comments

brulain’s picture

Status: Active » Closed (fixed)

Hi,
I have created an input format with 'Line break converter' unchecked.
Bye.

boclodoa’s picture

(I need the line break converter :S)

I'm making a digital version of an impressed document and I want to use this module to replace the footnotes. My problem is that sometimes before the [popup ...] appears a line break, so I get my lines broken. ¿can I control this behavior with a configuration parameter?

Example:

... for details see [popup text='Albert, the existence of life' effect=fade title='(1)' link=/], and many others.

and the result is

... for details see 
(1), and many others.
boclodoa’s picture

Status: Closed (fixed) » Active

help please

boclodoa’s picture

Priority: Normal » Major

I've tried to solve it my self but is not as easy as I suspected.

The base problem is: this module substitutes [popup ...] to

...

and a 'div' tag inside a 'p' tag is (in principle) not allowed, then the browser tries to fix it but don't display what I want.

other discussions on this topic:
http://www.webmasterworld.com/html/3560080.htm
http://blog.programmingsolution.net/html/html-div-tag-inside-html-p-para...
http://www.webmasterworld.com/forum83/2481.htm
http://www.cs.tut.fi/~jkorpela/html/nesting.html

So, even if the drupal filter configuration is working fine, the browser gets confused and the firebug too, you can see that is different the HTML code in firebug, and the HTML you can see with Ctrl+u.

Then my suggestion is to change the code of this module for use 'span' instead of 'div'. This is not single line change because it's necessary to change all the references (css and js) to the 'div' tags with references to 'span' tags.

Scheepers de Bruin’s picture

Actually it is a two line change.

Edit popup-element.tpl.php in whatever popup style you are using, and change:

<div id="<?php print $css_id;?>" class="<?php print $class;?>">
  <?php print $title; ?>
  <?php print $body; ?>
</div>

to

<span id="<?php print $css_id;?>" class="<?php print $class;?>">
  <?php print $title; ?>
  <?php print $body; ?>
</span>

I cannot recall why I specifically made that a div (there was some reason, possibly cross-browseriness), but if you're satisfied that that works, I may change it in the new release.

Please let me know.

Scheepers de Bruin’s picture

Status: Active » Closed (won't fix)

No longer supported