on #567112: DrupalDefaultEntityController::load() fails if query has more than one row with same "key", causing taxonomy load problem, sfyn suggested "the inclusion of help text on the taxonomy edit page to direct people to add taxonomies to content types via content types > manage fields". I second that, because coming from Drupal 6, I was expecting to be able to add taxonomies to content types via the taxonomy vocabulary page.

Comments

sfyn’s picture

Priority: Normal » Minor
Status: Active » Needs work
StatusFileSize
new672 bytes

@D7csmtl

I have made a little patch for this function. But it has typos.

sfyn’s picture

StatusFileSize
new658 bytes

@D7csmtl

And here's a better patch that will actually work!

sfyn’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, taxonomy-719424-2.patch, failed testing.

sfyn’s picture

Status: Needs work » Needs review
StatusFileSize
new692 bytes

reroll

sfyn’s picture

Issue tags: +D7csmtl
Hani’s picture

#5: taxonomy-719424-5.patch queued for re-testing.

joachim’s picture

> I second that, because coming from Drupal 6, I was expecting to be able to add taxonomies to content types via the taxonomy vocabulary page.

There's a case to be made for this being a UI regression, and that we should keep that UI in.

Status: Needs review » Needs work
Issue tags: -D7csmtl

The last submitted patch, taxonomy-719424-5.patch, failed testing.

alberto56’s picture

Status: Needs work » Needs review
Issue tags: +D7csmtl

#5: taxonomy-719424-5.patch queued for re-testing.

alberto56’s picture

Priority: Minor » Normal
Status: Needs review » Reviewed & tested by the community

Works fine for me on latest HEAD -- setting this to RTBC.

Also, I'm setting this to normal because the user experience differs a lot from previous versions of Drupal and some information may be needed to nudge new users of 7.x in the right direction and to avoid frustration -- the new 7.x way of assigning taxonomies to content types is far from obvious for users used to 6.x.

In Drupal 6.x, one would create a vocabulary and assign it to content types on the same page.

In Drupal 7.x, the procedure is:

  • Edit the vocabulary.
  • Go to the content type's manage fields tab.
  • Create a new Term reference field.
  • Assign the term reference to the correct vocabulary.

See also: #897520: Usability: "Taxonomy term reference" might be better than "Term reference".

ryivhnn’s picture

Patch works fine for me using alpha6.

I thought I'd forgotten or broken something when I couldn't work out where to apply vocabularies to content types. After figuring it out I actually prefer D7's way a lot more so wouldn't call it a UI regression, just minor confusion :) Would it be worthwhile indicating on the content type creation form where you would set up the vocabularies to apply to the content type?

yched’s picture

Status: Reviewed & tested by the community » Needs work
+++ modules/taxonomy/taxonomy.admin.inc	2010-02-19 10:50:24.000000000 -0500
@@ -110,6 +110,10 @@ function taxonomy_form_vocabulary($form,
+    '#markup' => t('Edit your taxonomy here, and apply it to !link in the manage fields tab', array ('!link' => l(t('content types'), 'admin/structure/types'), ) ),

- admin/structure/types has no 'Manage fields' tab. It's a list of node types, each one having a 'Manage fields' link.

- All entities can use taxo fields : comments, users, contrib entities... - not just nodes.
'Taxo field on nodes' is the most common use case, and is likely to be the 1st one people coming from the D6 way will be looking for, but we should not have a hardcoded UI text that makes it seem restricted to nodes, because people adding taxo fields to non-nodes will get the feeling they're doing something 'wrong'.

+ patch has spaces in an empty line

Powered by Dreditor.

alberto56’s picture

Status: Needs work » Needs review
StatusFileSize
new660 bytes

Interesting. Coming from Drupal 6, it did not occur to me that taxonomy can apply to anything... I removed the extra space, changed the text to "Edit your taxonomy here, and apply it using the manage fields tab of content types, users, or any other entity.", and added a period to the end of the text.

Albert.

sfyn’s picture

StatusFileSize
new661 bytes

I just tested this on a local drupal 7 instance. Here is one last adjustment to the wording - changed tab for link.

alberto56’s picture

Status: Needs review » Reviewed & tested by the community

Seems just about right to me. I would love to see this (along with #897520: Usability: "Taxonomy term reference" might be better than "Term reference") get into the next release as I have the feeling a lot of people will be lost as to how to use taxonomy in D7 otherwise.

I'm setting to RTBC, although I'm not clear on whether I have the moral authority to do so, seeing that I participated in writing a modification to the patch.

sun’s picture

Status: Reviewed & tested by the community » Needs review
Issue tags: +Needs usability review

um, this requires UX team review. And be aware that the UX team needs screenshots...

joachim’s picture

Status: Needs review » Needs work

This should be added using hook_help(), not set in the form, surely.

Also, I've tried the patch, and the new text seems to be at admin/structure/taxonomy/add. Why here, and not the main taxonomy page? This already says:

> Taxonomy is for categorizing content. Terms are grouped into vocabularies. For example, a vocabulary called "Fruit" would contain the terms "Apple" and "Banana".

It seems to me the "Taxonomy is for categorizing content" statement could be expanded on here. There is in fact an explanation of how to apply taxonomy vocabs to other entities at admin/help/taxonomy -- we should briefly say what's possible and link to that page.

Patch also produces text that looks wrong at admin/structure/taxonomy/forums/edit.

davidneedham’s picture

Any updates since the official release? FWIW, I agree with joachim.

uNeedStuff’s picture

Description

Currently there is no text to indicate what happens with newly created vocabularies. No instruction or simple explanation on how they get assigned to a content type for use. In D6 it was part of creating the vocabulary. This is very confusing, and I believe the thought will be that once it is created it will just show up for selection when creating content. That it then needs to be added to the content type after you create the vocabulary in a completely different area isn't indicated anywhere, this is not intuitive to a user.

I would suggest two changes.
1. On the Taxonomy landing page (I think that's what you call it) where it says currently:
Taxonomy is for categorizing content. Terms are grouped into vocabularies. For example, a vocabulary called "Fruit" would contain the terms "Apple" and "Banana".
Should include:
Add a term reference field to any content type you want your created vocabularies to include.

2. On the Structure page where it says:
Manage content types, including default status, front page promotion, comment settings, etc.
Should be changed to:
Manage content types, including default status, front page promotion, comment settings, assigned vocabularies, etc.

You may also want to add a note to the admin/structure/taxonomy/add page
After creating your vocabulary add a term reference field to all the content types you would like to include this new vocabulary.

Bojhan’s picture

Issue tags: -Needs usability review

no screenshots

eliza411’s picture

I created a new patch that addresses only the scope of the original issue.

It adds the following text to admin/structure/taxonomy:
A vocabulary is assigned to content types, users, or other entities on the manage fields tab by adding a Term reference field.

I've observed that Term reference is a confusing label for some new users who just created a vocabulary and want to add the vocabulary to a content type, but I think renaming fields requires more consideration and getting help text on the taxonomy page is valuable.

jlanaux’s picture

Thank you so much for posting this. I was fighting with this all morning. :)

Bojhan’s picture

Sounds fine!

alberto56’s picture

Status: Needs work » Needs review

Setting this issue to "needs review" to trigger the test bot.

Status: Needs review » Needs work
Issue tags: -Usability, -D7csmtl

The last submitted patch, taxonomyhelptext-719424-16.patch, failed testing.

yoroy’s picture

Version: 7.x-dev » 8.2.x-dev
Component: taxonomy.module » user interface text
Issue summary: View changes

Still a good idea. Lets try and make it a bit shorter though.

yoroy’s picture

Issue tags: +ux-workflow, +ux-interfacetext

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.0-beta1 was released on August 3, 2016, which means new developments and disruptive changes should now be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.0-alpha1 will be released the week of January 30, 2017, which means new developments and disruptive changes should now be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

smustgrave’s picture

Status: Needs work » Postponed (maintainer needs more info)
Issue tags: +stale-issue-cleanup

Thank you for sharing your idea for improving Drupal.

We are working to decide if this proposal meets the Criteria for evaluating proposed changes. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or there is no community support. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

smustgrave’s picture

If this is still desired can the summary be updated with screenshots.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.