The 2026 Drupal Business Survey is open. Your response will help shape the future of the Drupal business ecosystem.I noticed a FIXME in the code, so I fixed it. This cleans up views_view_page. This may not be the best way to do it, but it works for me. I've tested it, but not on a view that uses arguments.
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | cleanup_cleaned_up.patch.txt | 3.69 KB | wrunt |
| #1 | views_view_page.patch_0.txt | 3.5 KB | wrunt |
| views_view_page.patch.txt | 3.51 KB | wrunt |
Comments
Comment #1
wrunt commentedoops, that patch was backwards. Here's one that goes the right way.
Comment #2
merlinofchaos commentedI need to study this patch more when I'm more awake, but having simply '$args' as the second argument is unfortunately wrong. You need to do a func_get_args or, er, whatever it's called (back to 'not very awake') and pull them out that way. What can go away is trying to deconstruct a view based upon slashes et al.
Comment #3
wrunt commentedOk, I'll look into it.
Comment #4
wrunt commentedYeah, it won't work. I think I've misunderstood how the callback arguments work in the menu system. I wanted to add an argument to views_view_page for this views exporting patch, but maybe I should do it a different way.
Comment #5
wrunt commentedOk, I finally worked out what was going on with those callback arguments. The menu system adds arguments.
Here's a version that I'm pretty sure works.
Comment #6
merlinofchaos commentedCommitted! ONly 2 months later! =)
Comment #7
(not verified) commented