Posted by jm.federico on February 20, 2010 at 12:19am
2 followers
| Project: | Ubercart Ajax Attribute Calculations |
| Version: | 6.x-2.0 |
| Component: | Code |
| Category: | feature request |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | needs work |
Issue Summary
Hi
I have a patch that makes uc_aac hide the price difference if JavaScript is enabled.
The idea is that, since uc_aac updates the product price, there is no need for the attributes to show the difference. BUT when there is no JavaScript difference should be shown.
Right now if one chooses not to show the price difference, form the attributes settings page, they never get shown, but that is a problem for people without JavaScript. If one chooses to show the difference, it is always shown, and seems a bit redundant, because at the end of the day, uc_aac is meant to get read of that need.
The way I do it is by checking if "uc_aac" is one of the parameters given in the URL, as it is passed when uc_aac gets the new values.
Cheers
Comments
#1
So, I forgot the patch.
Here it is
#2
Fixed the "tab issue"
Purely cosmetic change
#3
jm.federico,
I like this idea but there are a couple of issues with your patch:
1. I see this as a feature, not a bug. Some users may always want a price adjustment or total displayed whether Javascript is enabled or not, therefore a admin setting enabling/disabling this option should be provided.
2. This would change the default behaviour of uc_aac and could confuse users. The option needs to be enabled by default for new users but disabled by default for existing users. This can be done using an update in uc_aac.install.
3. There is a bug where the price adjustment is incorrect when Javascript is disabled and the default option for an attribute alters the price.
This is all I have so far. I look forward to seeing this added to uc_aac eventually.
Cheers,
Antoine
#4
Antoine,
I'll work on the admin option to enable/disable this
Also, could you give me some more info about the bug in 3? How do you have the attribute set-up, mandatory, not, select box, radio, checkboxes. I'll try to reproduce and get a solution.
Federico ;)
#5
Federico,
The bug in #3 turns out to be a bug in the module in it's current form. I will work on a fix for this.
Cheers,
Antoine