Ad Node details shouldn't be public

You need to enable "Ad Owners" module.
But then not necessary tabs appears, I hide them in template.php

Even when I enable "Ad Owner", the ad node is still public...
Could someone explain why?

I have the same issue.

The node that the ad is in is public. The statistics and other things are not. However, the node itself should not be made public and only accessibly to owners.

I'm chiming in - and hope a fix will be made available.
Ad nodes should not be displayed as "pages", only using views and blocks. The recommended fix to add the no-index meta tag makes no sense. Only the owner and/or admin should be able to access the node, for everyone else: 404 (if they somehow find the url).

Peter

+1

unsubscribe please

+1

A hacky way to do this is to set the ad node to unpublished, but the ad status to active. When you set it to unpublished, it'll auto set it to expired. Once it does that, go back in and set it to active which will leave it unpublished and unvieweable to other users. Not a good solution, but it worked in my tests.

I agree, not a good solution. The not published/active state hides the node from ad owners as well.

I found that if I only display the $node->content['ad']['#value'] variable for that node through content templates, then I only lose the up front statistics and status messages, yet ad owners can still access the reports tab for the same statistics.

For non-ad-owners, all they get is the node title and image presented as an ad.

Satisfactory solution for now.

In the future, it would be nice to access these variables using views and then filter based on ad owner and other ad status values.

For me, enabling the ad_owners module does it.

The Ad Owners module will remove the statistics, but the page remains. You can also get a list of all ads in a category by clicking the tag at the bottom. On a test site, I am able to do this as an anonymous user.

I think you can solve this with the Rules module.

You add a triggered rule: Content is going to be viewed
Set the conditions: Content has type Advertisement, Acting user is not the same as content author, Acting user doesn't have the "Editor" role
Action: for example do a redirect to the front page

You can also use ctools page_manager to redirect away from the ad node or display the access denied page.

Another alternative, also not 100% ideal.. could replace the goto with drupal_access_denied etc if preferred.

function MYMODULE_nodeapi(&$node, $op, $arg3, $arg4){
  switch ($op){
    case 'view':
      if($node->type == 'ad' && !user_access('administer advertisements')) {
          drupal_goto('<front>');
      }
    break;
  }
}

Just wanted to confirm that I was able to use the Rules module as outlined by #13. Good tip.

Its a huge problem for me, so i wrote a patch for it to ad.module file. Please check it and commit to source. Thx

Sorry, previously version was a little buggy, use this patch.

Confirm the problem. I don't use Ad Owners module, so ads on my site with all details (!!!) are in public.

It's a big problem.

I set the option which add "noindex" meta tag, but google bot ignores it and already gobbled up a lot of Ads and their details :(

I think the best way to resolve this is to split the "show advertisements" permission for showing ads and viewing nodes with all details.

Drupal 6 is EOL and no longer supported. Closing this as outdated for that reason. Thanks for your contribution!