simpletest xpath error handling

Appending the test file with some more test cases

This is really cool, but I'm noticing a problem with it - the xpath throws warnings when it hits paths like //a[@href="http://example.com/s549952LRefyAJT" and text()="s549952M5g5RZzD<script>alert("hi");</script>"]. I think this is because text() is supposed to be searching for *only* text nodes, and by putting the <script> tag inside of the text, it no longer qualifies as a text node.

XML is hard. :)

I'm working on trying to come up with a method to do the tests you want to do, but stop errors from popping up. Well, not errors, warnings.

Hm. Well, you seem to really need that to fail, because you're testing to see if nothing is found if the link type isn't good. So, I put libxml_use_internal_errors(TRUE) before your call to $this->xpath(), and libxml_use_internal_errors(FALSE) afterwards. That way the warnings we don't want to see, but expect, don't cause us any trouble.

I'm going to include this into the project. Thanks!

And, might as well set it as fixed. Thanks for the help!

Looks good.

This patch works for me, although it could use a code comment. I had to look up libxml_use_internal_errors() to understand what the patch does, and then had to know Drupal to understand why we're not using a custom error handler. So, can we add a little bit of documentation to describe this test and its implementation? Thanks!

#8: libxml_use_internal_errors.patch queued for re-testing.