Make module compatible with Views 3 (currently available in alpha).

CommentFileSizeAuthor
#5 views-3-x-compatibility-720600-5.patch1.19 KBgrasmash

Comments

Renee S’s picture

Renee S commented

+1 for this. Everything seems OK except that the field 'string formatting' settings don't apply.

Renee S’s picture

Renee S commented
Status: Postponed » Active

I've changed this back to active, as the last issue was posted almost a year ago. Would be great if a mod could weigh in on the feasibility of this, as Views3 is definitely awesome and fairly stable. :)

xjm’s picture

xjm
she/her
Primary language English
commented

I'm still not using Views 3 so I haven't had the need/opportunity to test it. Patches welcome!

Renee S’s picture

Renee S commented

Views3 is made of pure win. It's worth installing it just to enjoy using it :)

I won't have a chance to delve in and offer something myself for at least a month, probably two, but at that time I'll revisit and see if our work-arounds should be replaced by this module and at that time I'll take a closer look and see if I can send a patch your way.

grasmash’s picture

grasmash commented
Status: Active » Needs review
StatusFileSize
new views-3-x-compatibility-720600-5.patch1.19 KB

Adding patch for views 3 compatibility.

xjm’s picture

xjm
she/her
Primary language English
commented

Excellent! There's a bit of trailing whitespace, but no big deal to clean up. I'll test this on a 6.x sandbox with views 3.

grasmash’s picture

grasmash commented

It may also be a good idea to test this with Views 2.x. I've only tested in in Views 3.x.

xjm’s picture

xjm
she/her
Primary language English
commented

Ah, yes, fair point. :)

grasmash’s picture

grasmash commented

If it doesn't work, it might make sense to just branch the project for views 3. Let me know if you run into any trouble. I haven't done too much work with integrating modules with Views (does documentation even exist?) but I'd like to figure it out.

summit’s picture

summit commented

Hi, Is this patch committed please?
Greetings, Martijn

xjm’s picture

xjm
she/her
Primary language English
commented

No, it's set to "Needs Review," which means it needs to be reviewed. You can help this issue move forward by testing the patch with Views 2 and/or Views 3 and reporting your results.