With Domain Settings committed #713026: Domain Settings: enable all system settings forms, we now have cases where hook_domainwarnings() is possibly overridden by the new module.

See the attached.

What to do?

CommentFileSizeAuthor
#4 721148-warnings.patch2.97 KBagentrickard
Picture 1.png71.75 KBagentrickard

Comments

nonsie’s picture

nonsie
she/her
Primary language Estonian
commented

A puzzle indeed - one uses hook_domainwarnings while the other uses hook_form_alter. Part of me wants to say let's disable hook_domainwarnings on forms that are in use with Domain Settings but it would mean writing condition checking into the main Domain module.

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented

Yup. The other alternative is peeking at the $_SESSION['messages'] array...

nonsie’s picture

nonsie
she/her
Primary language Estonian
commented

Messing with $_SESSION IMHO is worse than writing a condition into Domain for Domain Settings...

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented
Status: Active » Fixed
StatusFileSize
new 721148-warnings.patch2.97 KB

Hooray for drupal_alter()!

Committed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.