Posted by agentrickard on February 21, 2010 at 7:39pm
| Project: | Domain Access |
| Version: | 6.x-2.x-dev |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed (fixed) |
Issue Summary
With Domain Settings committed #713026: Domain Settings: enable all system settings forms, we now have cases where hook_domainwarnings() is possibly overridden by the new module.
See the attached.
What to do?
| Attachment | Size |
|---|---|
| Picture 1.png | 71.75 KB |
Comments
#1
A puzzle indeed - one uses hook_domainwarnings while the other uses hook_form_alter. Part of me wants to say let's disable hook_domainwarnings on forms that are in use with Domain Settings but it would mean writing condition checking into the main Domain module.
#2
Yup. The other alternative is peeking at the $_SESSION['messages'] array...
#3
Messing with $_SESSION IMHO is worse than writing a condition into Domain for Domain Settings...
#4
Hooray for drupal_alter()!
Committed.
#5
Automatically closed -- issue fixed for 2 weeks with no activity.