Download & Extend

make drag icon position align better

Project:Drupal core
Version:7.x-dev
Component:dashboard.module
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed (fixed)
Issue tags:Usability

Issue Summary

anyone notice that drag icon position is not so good ?
I can submit a patch if it is the mistake.

AttachmentSizeStatusTest resultOperations
22-2-2010 4-50-17.png9.69 KBIgnored: Check issue status.NoneNone

Comments

#1

#2

Status:closed (duplicate)» active

As rule, if two issues report the same bug, the one created last gets marked duplicate. Sometimes the more recent one has better comments or working patches, then it's ok to proceed in the newer one.

ff1: please repost your CSS code example here.

#3

Nevermind, here it is.

From:

#dashboard .ui-sortable .block h2 {
  background: transparent url(../../misc/draggable.png) no-repeat 0 -35px;
  padding: 0 1em;
}

#dashboard #disabled-blocks .block:hover h2 {
  background: #0074BD url(../../misc/draggable.png) no-repeat 0 -35px;
  color: #fff;
}

#dashboard .dashboard-region .ui-sortable .block:hover h2 {
  background: #0074BD url(../../misc/draggable.png) no-repeat;
  background-position: 3px -32px;
  color: #fff;
}

To:

#dashboard .ui-sortable .block h2 {
  background: transparent url(../../misc/draggable.png) no-repeat 0 -39px;
  padding: 0 0.5em 0 1.5em;
}

#dashboard #disabled-blocks .block:hover h2 {
  background: #0074BD url(../../misc/draggable.png) no-repeat 0 -39px;
  color: #fff;
}

#dashboard .dashboard-region .ui-sortable .block:hover h2 {
  background: #0074BD url(../../misc/draggable.png) no-repeat;
  background-position: 3px -36px;
  color: #fff;
}

Patch welcome!

#4

Version:7.0-alpha2» 7.x-dev

version

#5

I got a patch :)
I'll upload some screenshots

AttachmentSizeStatusTest resultOperations
move_error.patch1.02 KBIdlePASSED: [[SimpleTest]]: [MySQL] 18,729 pass(es).View details

#6

Status:active» needs review

:)

AttachmentSizeStatusTest resultOperations
chromeArrow.png201.15 KBIgnored: Check issue status.NoneNone
ffArrow.png556.95 KBIgnored: Check issue status.NoneNone
ieArrow.png212.73 KBIgnored: Check issue status.NoneNone
operaArrow.png199.97 KBIgnored: Check issue status.NoneNone

#7

Status:needs review» reviewed & tested by the community

Safari looks good too. Thanks!

#8

Status:reviewed & tested by the community» fixed

Committed to CVS HEAD. Thanks.

#9

Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.