Hi,
How do i get rid of the moderation tab when a anonymous user views a node?
I've check my permissions but it doesn't seem to have anything to do with them.

Thanks

CommentFileSizeAuthor
#23 content_moderation_history_permission.patch454 bytesbroon
#23 content_moderation_right_spelling.patch454 bytesbroon
#18 moderation_permission3.patch2.7 KBbroon
#16 moderation_permission2.patch2.32 KBbroon
#14 moderation_permission.patch1.65 KBbroon
#4 moderation_tab.png48.18 KBsskully

Comments

EugenMayer’s picture

EugenMayer commented

You can use the block-visibilty permissions and set it to "authenticated user"

EugenMayer’s picture

EugenMayer commented
Category: task » support
EugenMayer’s picture

EugenMayer commented
Status: Active » Fixed

confirmed, using the block permissions works.

sskully’s picture

sskully commented
StatusFileSize
new moderation_tab.png48.18 KB

Sorry I should have been more descriptive.
By tab, I was talking about the tabs on the top of the node when it is viewed.
Right now it shows the "view" and "moderation history"tab at the top of the page.

I've uploaded a screen capt.

Thanks for all your help!

EugenMayer’s picture

EugenMayer commented
Status: Fixed » Active

Oh well, now i get you. I guess we need an extra user permission for that for each content type "access history for node type X". Well this will be a feature which is easy to implement but yet we have a feature freeze due the release candidate.

I might find time to provide you a patch for this feature, but well, depends on my schedule. Just bumb this thread from time to time :)

EugenMayer’s picture

EugenMayer commented
Title: how do i not display the moderation tab? » Make the local task "moderation history" hidden by user permission
Category: support » feature
Dr Jay’s picture

Dr Jay commented

seconded and subscribed

Dr Jay’s picture

Dr Jay commented

BTW, the temporary CSS hack I'm using is .not-logged-in .local-tasks {display:none;} in case that helps you.

j0k3z’s picture

j0k3z commented

+1 I really need this feature.

sskully’s picture

sskully commented

Any Progress on this fix?
I can't use this module if my unregistered user can view all the revisions.

Thanks

EugenMayer’s picture

EugenMayer commented

skully, iam currently not working on it, feel free to provide patches (rather easy job here). Otherwise use CSS as #8 to hide those.

sskully’s picture

sskully commented

I hope I didn't offend you, I think your project is great.
And I am in no way a talented enough programmer to do any patches.
I did try the CSS, but it didn't work for me. I'm sure I'm just missing something.
I'm sure you are really busy and I really would appreciate you applying this feature once you get the chance.

Thanks for you help!

EugenMayer’s picture

EugenMayer commented

skully there was no offence, so dont worry. Iam just also busy doing other things but i see people really interested in that feature urgently. Just also hoping people doing more then writing feature requests :)

broon’s picture

broon
Location Potsdam
commented
Version: 6.x-1.0-rc2 » 6.x-1.0
Status: Active » Needs review
StatusFileSize
new moderation_permission.patch1.65 KB

Here's a quick patch which is working for me.
Since this is my first patch (in contrast of posting code formerly) and additionaly it's created on a Windows machine I don't know if it's working automatically. At least modfication by hand should get it going.

Best,
Paul

EDIT: As I am currently testing this module the patch provided above already contains a fix for another problem.

EugenMayer’s picture

EugenMayer commented
Status: Needs review » Fixed

Thank you very much sin.star for helping out here. Sure people are glad to see this feature come in. Applied both

broon’s picture

broon
Location Potsdam
commented
StatusFileSize
new moderation_permission2.patch2.32 KB

Actually the patch fails as the permission never shows up on permission settings page. After unsuccessfully blaming permission cache for that I found a typo in the function content_moderation_perm. There the rights array spells "rigths". Corrected the typo in my updated patch (against 6.x-1.0).

Best,
Paul

EDIT: Again, this patch also includes the correction for the editors link in drupal_set_message as mentioned above.

EugenMayer’s picture

EugenMayer commented

Also missed that one. Fixed.

broon’s picture

broon
Location Potsdam
commented
StatusFileSize
new moderation_permission3.patch2.7 KB

I'm sorry, but I missed something, too. Changing the permission names also requires to change the proper names in relevant access function. So here is the next (hopefully last) patch regarding this issue.

Best,
Paul

EugenMayer’s picture

EugenMayer commented

Well yes, all true.

included that patch and made a release : http://drupal.org/node/738330

EugenMayer’s picture

EugenMayer commented
Status: Fixed » Closed (fixed)

fixed and released in 1.1

sskully’s picture

sskully commented

Thanks Eugen!
This is a great project!

EugenMayer’s picture

EugenMayer commented

sskully thanks should go to sin.star - he implemented it completely and provided the patch. Actually all i did (nearly) is commit them :)

Any thanks!

broon’s picture

broon
Location Potsdam
commented
StatusFileSize
new content_moderation_right_spelling.patch454 bytes
new content_moderation_history_permission.patch454 bytes

As I found the patch missing from 1.2 here's a new one. ;)
(No changes actually to the one before except for line numbers.)