As the Google Gears project has been as good as discontinued it would be better to go with an standards only (HTML5) approach in the main module.

It might, however, be worth looking into making the module a bit more modular to allow sub-modules to add support for third-party solutions until the web becomes a little more standards compliant.

Comments

drzraf’s picture

Version: 6.x-1.x-dev » 7.x-1.x-dev
Status: Active » Needs review
StatusFileSize
new2.39 KB

+1 (obvious patch attached, untested)
Ideally, I think jQuery is the way to go on the subject of browser abstraction.
I know of three multiple files upload implementations:
https://github.com/blueimp/jQuery-File-Upload
http://code.google.com/p/jquery-html5-upload/
https://github.com/hermanbanken/html5-file-uploader

Let's choose the right one
I let you switch this issue to D7 if you want to but I mark "needs review" anyway

petsagouris’s picture

StatusFileSize
new10.64 KB

Here is a patch for this that removes the google gears support completely. (From README.txt, .module, and .js files).

petsagouris’s picture

StatusFileSize
new10.64 KB

Sorry wrong patch attached in last reply. Here is the correct one.

drzraf’s picture

sorry to be so negative but from my short experience of Drupal, I'm quite sure your patch will be refused as it change indentation instead of Google Gears code only.
you may want to use git diff -w to skip whitespace related changes, but you'll still have to revert line-breaks ...

petsagouris’s picture

StatusFileSize
new5.35 KB

No negativity received, thanks for your comment. I didn't know about the whitespace issue, here is another version of the same patch hopefully more complete.

deciphered’s picture

Status: Needs review » Fixed

Committed to 7.x-1.x.

Cheers,
Deciphered.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.