Fix taxonomy integration

More info on this: when you create a Term view (taxonomy as base taxonomy), create page of it, visit that page -- you get the following error:

PDOException: SQLSTATE[42S02]: Base table or view not found: 1146 Table 'd7.term_data' doesn't exist: SELECT term_data.name AS term_data_name, term_data.vid AS term_data_vid, term_data.tid AS tid, term_data.description AS term_data_description FROM {term_data} term_data; Array ( )  in views_plugin_pager->execute_count_query()  (line 141 of /Users/renelle/workspace/d7/sites/all/modules/views/plugins/views_plugin_pager.inc).

It seems similar to #763650: PDOException: SQLSTATE[42S02] and #784144: Sort by taxonomy term name throws PDO exception, table not found -- the problem being that some tables were renamed in D7 and not updated in views7. This patch works for me. (How do you trigger simpletest on uploaded patches?)

Ok, found this issue when playing with Views on Drupal 7 which prevented further work on a test site, so I took a stab at it. The patch attached is thus the one attached in #3 plus the necessary rename from term_node to taxonomy_index, and takes care of the vid => nid renaming.

It makes the default Taxonomy view almost usable (yeah !), if it weren't for the fact that the node "Published or admin" filter seems completely broken in a fresh checkout, but I'll fill a new issue for that if I don't find an already existing one.

There's something else that seems broken, as I get Notice: Undefined index: validate_argument_transform dans views_plugin_argument_validate_taxonomy_term->convert_options() (line 68 of /var/www/ows/serie/sites/all/modules/views.git/modules/taxonomy when viewing the page. I haven't looked into it yet, but I'll do if no one beats me to it.

Finally, due to the fact that taxonomy_index no longer contains a vid, but only an nid, there's no way anymore to establish a direct relationship between taxonomy_term_data and node_revisions, like the code used to in D6. I suppose it's ok, as you should be able to add two relationships, to go from node_revision to node and then from node to term, but maybe that should be taken care of in the conversion process ?

Found the "Published or admin" issue, its #799604: Complex views no longer work, won't talk about it here anymore.

Found another problem in views_plugin_argument_default_taxonomy_tid.inc when playing around: there's no longer a taxonomy property on the node object. Attached patch iterates over the fields attached to the entity, looking for taxonomy_term_reference one to build an array matching what $node->taxonomy used to look like.

I'm not too sure how to go about adding a generic term_data => node_revisions relationship that doesn't imply adding every taxonomy term reference field table to the query, which is going to be a possibly major performance hit if you have a lot of fields. Maybe that should be an explicit relationship, with a configuration screen, allowing you to choose which field you want to take into account ? Or every taxonomy term reference field should created its own relationship between the terms and node tables ?

Subscribing...

Subscribing.

subscribing

Subscribing

Cool, will give it a spin on my site over the next days. Let you know how it works.