this was first posted by Flying Drupalist at #722738: Fieldset title option not working
and being a different issue I split it
I've also been trying to get rid of the fieldset all-together, and rather use my own theming solution with this.
I don't know if this is a separate issue, but it would be nice if in cases when there is no name set in the fieldset name option, no fieldset is created.
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | 2010-02-22_theme_[type]_node_form[unix].patch | 1.53 KB | arhak |
Comments
Comment #1
arhak commentedconsider the options:
- you may theme the node_form to your likings and it should be inherited by the driven fieldset
- I found a typo bug in line 555
$node_type . '_node_form'was intended to be in the #theme list but it reads$node_tpyeinstead, and might be the reason sopping your theming (try the attached patch)- you got a narrower selector #driven_node_container with the form in it
- you may have the fieldset collapsed or expanded
- you may have the fieldset above or bellow the comment form (at work I have it expanded and bellow the comment form), bare in mind that this feature is currently supported but has no UI yet, you can go to your
{variable}table and insert a variable with namecomment_driven:node_form_bellowand valuei:1;and every driven fieldset will appear bellow comment formdo you still need more theming support?
lets do a trial, disable JavaScript and refresh your pages, tell me how much do you like it without the fieldset (yes, the "wrap into a fieldset" action is handled via JS in the client side)
Comment #2
arhak commentedneeds review BTW
Comment #3
arhak commentedcommitted to HEAD
Comment #4
arhak commentedsorry, don't know yet if the theming issue still applies after this fix
Comment #5
arhak commentedanyway, I made it available in passing by, now committed to HEAD
Comment #6
arhak commented