Remove the moderation flag from existing SQL [#72343]

Comment	File	Size	Author
#9	book_stray_moderation_message.patch	826 bytes	dww

#3	moderate_0.patch	17.12 KB	Chris Johnson

Comment #1

yched CreditAttribution: yched commented 6 July 2006 at 11:38

(subscribing...)

Log in or register to post comments

Comment #2

pwolanin CreditAttribution: pwolanin commented 6 July 2006 at 12:46

I haven't gotten on the devel list, but I assume this comes out of this issue for 4.7: http://drupal.org/node/71730

A proposal there is to have status have possible values 1,0,-1.

http://drupal.org/node/71730#comment-112943

Though I might prefer to call these states published, unpublished, and hidden. In this case, i'd think nodes with status =0 should (at least) be accessible to their author (unlike the current system).

Log in or register to post comments

Comment #3

Chris Johnson CreditAttribution: Chris Johnson commented 9 July 2006 at 16:07

Status:

Active

» Needs review

File	Size
moderate_0.patch	17.12 KB

Here's a patch for HEAD core which removes the moderate flag from all code references. It is not removed from the database.

I benchmarked this before and after, and while it was a tiny bit faster after, I don't think the improvement is statistically signficant (about half a second over 1000 requests using ApacheBench at concurrency 10) on my system (500 nodes, 500 comments, 50 users, 15 taxonomies, 50 terms, 20 nodes on front page, benchmark was just hitting front page).

Log in or register to post comments

Comment #4

Dries CreditAttribution: Dries commented 10 July 2006 at 08:05

Status:

Needs review

» Needs work

Committed this patch to CVS HEAD. This needs to be documented in the upgrade instructions. Setting this to 'code needs work'. Please set 'fixed' when the handbook has been updated.

Log in or register to post comments

Comment #5

Chris Johnson CreditAttribution: Chris Johnson commented 10 July 2006 at 14:15

Suggested documentation submitted to handbook and issue http://drupal.org/node/73015 opened to indicate need for changes created.

Log in or register to post comments

Comment #6

kbahey CreditAttribution: kbahey commented 10 July 2006 at 14:27

Why keep the moderate column in the database?

Log in or register to post comments

Comment #7

moshe weitzman CreditAttribution: moshe weitzman commented 10 July 2006 at 14:38

Just reading this patch now ... The following line should is a 'publish' action, not approve:

+ 'approve' => array(t('Approve the selected posts'), 'UPDATE {node} SET status = 1 WHERE nid = %d'),

Log in or register to post comments

Comment #8

pwolanin CreditAttribution: pwolanin commented 10 July 2006 at 16:26

I think it's useful to keep the moderate column- otherwise you may break people's existing data. Also, it would then be easier for contrib modules to implement a moderation workflow.

Log in or register to post comments

Comment #9

dww

we/he/they

CreditAttribution: dww commented 7 August 2006 at 10:19

Assigned:	Chris Johnson	» dww
Category:	task	» bug
Status:	Needs work	» Needs review

File	Size
book_stray_moderation_message.patch	826 bytes

the previous patch (which was committed to HEAD) removed a check for the moderation bit from book.module, but left the underlying message that said "The post has been submitted for moderation and won't be accessible until it has been approved." attached patch removes this (now bogus) message for site admins viewing book nodes.