The breadcrumb home link in a multilanguage website is not correct. In all languages point the link to frontpage of the default language.

My little patch corrects this error.

CommentFileSizeAuthor
menu.inc.patch.txt368 bytesquiptime

Comments

dries’s picture

Status: Active » Needs review
drumm’s picture

Status: Needs review » Fixed

Committed to HEAD.

killes@www.drop.org’s picture

also to 4.7.

hitka’s picture

Are you sure that this is the correct way of fixing this problem?

Before the home link was pointing always for example to www.example.com. With this patch it points to www.example.com/node, or www.example.com/en/node in the multilanguage case. I think that ideally it would point instead to www.example.com for single-language sites (as before) and to www.example.com/en for multi-language sites.

I hope you get the idea. The implementation would be something like revert this patch and fix instead the l() function so that in the case it calls some hook or something, that would allow i18n module to supply the needed language code.

hitka’s picture

Status: Fixed » Needs work

If I am wrong, please just mark the bug again as fixed.

quiptime’s picture

I sent email at Jose A Reyero, maintainer from i18n.

harry slaughter’s picture

yes indeed, this patch resultedin complaints from other users:

http://drupal.org/node/78129

having multiple links to 'home' (a.b.com && a.b.com/node) is not acceptable to folks concerned with a theoretical google pagerank penalty for having identical content residing under different links.

it's also unsightly.

harry slaughter’s picture

ok, i am a bit lost.

i enabled i18l for testing. switched my user to spanish.

links are *not* changed. that is, homepage is still a.b.com NOT a.b.com/es

when/where are these /[language] links generated?

magico’s picture

Version: 4.7.2 » 5.x-dev
Status: Needs work » Postponed (maintainer needs more info)

The patch provided here was reverted.
Does this issue makes any sense?

ricabrantes’s picture

Status: Postponed (maintainer needs more info) » Closed (fixed)

This bug are closed..