Closed (fixed)
Project:
Drupal core
Version:
5.x-dev
Component:
menu system
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
5 Jul 2006 at 21:09 UTC
Updated:
3 Mar 2008 at 10:56 UTC
The breadcrumb home link in a multilanguage website is not correct. In all languages point the link to frontpage of the default language.
My little patch corrects this error.
| Comment | File | Size | Author |
|---|---|---|---|
| menu.inc.patch.txt | 368 bytes | quiptime |
Comments
Comment #1
dries commentedComment #2
drummCommitted to HEAD.
Comment #3
killes@www.drop.org commentedalso to 4.7.
Comment #4
hitka commentedAre you sure that this is the correct way of fixing this problem?
Before the home link was pointing always for example to www.example.com. With this patch it points to www.example.com/node, or www.example.com/en/node in the multilanguage case. I think that ideally it would point instead to www.example.com for single-language sites (as before) and to www.example.com/en for multi-language sites.
I hope you get the idea. The implementation would be something like revert this patch and fix instead the l() function so that in the case it calls some hook or something, that would allow i18n module to supply the needed language code.
Comment #5
hitka commentedIf I am wrong, please just mark the bug again as fixed.
Comment #6
quiptime commentedI sent email at Jose A Reyero, maintainer from i18n.
Comment #7
harry slaughteryes indeed, this patch resultedin complaints from other users:
http://drupal.org/node/78129
having multiple links to 'home' (a.b.com && a.b.com/node) is not acceptable to folks concerned with a theoretical google pagerank penalty for having identical content residing under different links.
it's also unsightly.
Comment #8
harry slaughterok, i am a bit lost.
i enabled i18l for testing. switched my user to spanish.
links are *not* changed. that is, homepage is still a.b.com NOT a.b.com/es
when/where are these /[language] links generated?
Comment #9
magico commentedThe patch provided here was reverted.
Does this issue makes any sense?
Comment #10
ricabrantes commentedThis bug are closed..