Adding an id attribute to each field displayed in the custom data list is a bad idea, especially in the Signup details table where the same fields will repeat for each user. We should instead use a class, to keep the markup valid.

CommentFileSizeAuthor
#1 signup-HEAD_custom_data_id.patch803 bytesdboulet

Comments

dboulet’s picture

StatusFileSize
new803 bytes

Just realized that the patch didn't attach correctly.

ezra-g’s picture

Status: Active » Fixed

[removed]

ezra-g’s picture

Status: Needs review » Active

Sorry, wrong window ;).

dboulet’s picture

Status: Fixed » Needs review