Currently, TAC's database tables are installed with CREATE TABLE queries specific to PostgreSQL and MySQL. Using the Schema API instead will improve portability, make a D7 port easier to accomplish, and allow for cleaner INSERT query syntax.

CommentFileSizeAuthor
#1 taxonomy_access-723668-1.patch9.47 KBxjm

Comments

xjm’s picture

xjm
she/her
Primary language English
commented
Status: Active » Needs review
StatusFileSize
new taxonomy_access-723668-1.patch9.47 KB

This patch implements hook_schema() in taxonomy_access.install. (There's no need for a hook_update_N() because the CREATE queries themselves aren't changing, just the source of the calls.)

I've tested this with MySQL and it works fine, but I haven't tested it with postgres.

xjm’s picture

xjm
she/her
Primary language English
commented
Status: Needs review » Needs work

Access permissions seem to need to be rebuilt frequently with this patch in both MySQL and PostgreSQL. Needs more testing.

xjm’s picture

xjm
she/her
Primary language English
commented
Status: Needs work » Needs review

Actually, the issue of the need for repeated rebuilds I mention in #2 (specifically after modifying TAC configurations) seems to occur in the unpatched module as well. So, it's unrelated to the patch. I'll open a new issue for that. Edit: refer to #727648: Node access not updated on default change for that bug.

xjm’s picture

xjm
she/her
Primary language English
commented

I've now tested this fairly thoroughly on both MySQL and PostgreSQL; the behavior is the same as the current dev build in every situation I tested.

xjm’s picture

xjm
she/her
Primary language English
commented
Status: Needs review » Fixed

Committed to 6.x-1.x-dev.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.