preg_match error on node_save

It happens to me as well after an update to 6.15.

I have a user that says this message appeared after he saved a node with images.

warning: preg_match() [function.preg-match]: Compilation failed: range out of order in character class at offset 53 in /home/admin/domains/.../public_html/beta/sites/all/modules/filefield_paths/filefield_paths.module on line 571

I'm running FileField Paths 6.x-1.4 and the latest Drupal release.

I am also seeing this. Not sure what's causing it. I've been uploading image files provided by a client, some of which contain spaces in their titles. Doubt that has anything to do with it, but worth mentioning. I'm using the [nid] replacement pattern only.

Subscribing. I'll let you know if I notice any other patterns.

I've tried it without the spaces in the titles, and it still happens. Just an FYI...

Hi guys,

Any more information you can provide about your environments? PHP version, OS, server technology?
I'm running FFP 1.4 with D6.15 on multiple sites and have not once come across this issue.

Also, is it actually breaking anything (other than aesthetics) or is just throwing the error?

Cheers,
Deciphered.

I have the same error. The file renaming worked flawlessly for about 100 or so image uploads then suddenly this bug appeared. Nothing in my setup changed.

    * warning: preg_match() [function.preg-match]: Compilation failed: range out of order in character class at offset 40 in /home/.../public_html/.../sites/all/modules/filefield_paths/filefield_paths.module on line 571.
    * warning: preg_match() [function.preg-match]: Compilation failed: range out of order in character class at offset 40 in /home/.../public_html/.../sites/all/modules/filefield_paths/filefield_paths.module on line 571.
    * warning: preg_match() [function.preg-match]: Compilation failed: range out of order in character class at offset 40 in /home/.../public_html/.../sites/all/modules/filefield_paths/filefield_paths.module on line 571.
    * warning: preg_match() [function.preg-match]: Compilation failed: range out of order in character class at offset 40 in /home/.../public_html/.../sites/all/modules/filefield_paths/filefield_paths.module on line 571.
    * warning: preg_match() [function.preg-match]: Compilation failed: range out of order in character class at offset 40 in /home/.../public_html/.../sites/all/modules/filefield_paths/filefield_paths.module on line 571.

Drupal 6.16
Filefield Paths 6.x-1.4
File Replacement Pattern: [field_photo-filefield-description]-[nid].[filefield-extension-original]
Cleanup using Pathauto + Convert to lowercase

Webserver:

Apache/2.2.14 (Unix) mod_ssl/2.2.14 OpenSSL/0.9.8e-fips-rhel5 mod_auth_passthrough/2.1 mod_bwlimited/1.4 FrontPage/5.0.2.2635 mod_fastcgi/2.4.6 Phusion_Passenger/2.2.5

PHP: 5.2.12
MySQL: 5.0.89

UPDATE...

I shut off "Cleanup using Pathauto" and the bug disappeared.

Then, to confirm, I re-enabled it, and no more bug.

Nostalgia: http://drupal.org/node/324736

BPB, where do you find the "Cleanup using Pathauto" setting? I'm still having this issue.

Ah, I found it. It's under the field settings for the file or image field.
So, admin/content/node-type/content-type/fields/field-name

I still get the error after turning off and on Cleanup using Pathauto.

I'm running D6.16. MySQL 5.0.41. PHP 5.2.5 128M, Apache 2. Running Linux, not sure what distro. FileField Paths 6.x-1.4

*bump*.
Nothing?

I just updated to the latest versions of ImageField (6.x-3.3) and FileField (6.x-3.3) and I still get this error.

Just updated to the latest version of FileField - 6.x-3.5 and the error still appears.

*bump*
Still seeing this error. Any thoughts?

In filefield_paths_filefield_paths_process_file, there is a section that will replace the new path inside the body. I don't completely understand the use-case for this (maybe it should be entirely deleted, maybe not), but the problem is it doesn't escape the arguments being passed into regexes.

So if you have a token like [blah-blah] in the regex argument, preg functions interpret that as an invalid character range (eg [a-z]) and spits the error. The fix is to escape the arguments we pass into a regex so they are treated as regular characters.

Patch attached.

@andrewlevine

The usecase is that if a user copies the path from the filefield before the node has been saved and the path has been corrected and inserts it into the Body field, which would cause a broken link. This is more obviously an issue when using the Insert module or the WYSIWYG ImageField module. It is definitely a necessary function.

As for the patch, looks good, will do some testing of it and if all is well expect to see it make it's way into the 2.x branch.

Cheers,
Deciphered.

Ah ha! I've "solved" the issue. Or, at least I know what the problem is.

So, I created another ImageField with the *exact* same settings as my original. The new one, however, behaved perfectly with no warnings. After much poking around in the DB I discovered the "widget_settings" and "display_settings" fields were different between the two in the "content_node_field_instance" table. I swapped those fields (new for old) and things worked.

I thought about it for a bit, and discovered that the old "widget_settings" field had this line in there:

s:9:"file_path";s:26:"project_pics/[author-name]"

Hmmm ... preg_match() is a regular expression matching function, which uses "[" and "]" as special characters. So, if it's trying to match that string, that's probably what's freaking it out. I'm not sure why the new field gets created without a file_path setting, but perhaps that's by design? Anyway, at this point, I'm not sure who's problem it is, but if anyone else is having this problem, I go and manually change your "content_node_field_instance" table, and edit the table entry for your Image Field and make sure there's no weird characters in the "file_path" portion of the "widget_settings" field. I *assume* you can change it to whatever you want, but I'm not sure.

I'll make a post in the ImageField issues queue and link here and see if they have any comments.

Here's the old "widget_settings" and "display_settings":

a:14:{s:15:"file_extensions";s:16:"jpg jpeg png gif";s:9:"file_path";s:26:"project_pics/[author-name]";s:21:"max_filesize_per_file";s:2:"1M";s:21:"max_filesize_per_node";s:2:"5M";s:12:"file_widgets";N;s:14:"max_resolution";s:1:"0";s:14:"min_resolution";s:7:"150x150";s:3:"alt";s:0:"";s:10:"custom_alt";i:0;s:5:"title";s:0:"";s:12:"custom_title";i:0;s:17:"use_default_image";i:0;s:18:"progress_indicator";s:3:"bar";s:10:"title_type";s:9:"textfield";}

a:8:{s:6:"weight";s:1:"1";s:6:"parent";s:0:"";s:5:"label";a:1:{s:6:"format";s:6:"hidden";}s:6:"teaser";a:2:{s:6:"format";s:6:"hidden";s:7:"exclude";i:1;}s:4:"full";a:2:{s:6:"format";s:19:"thumbnail_imagelink";s:7:"exclude";i:0;}i:4;a:2:{s:6:"format";s:11:"image_plain";s:7:"exclude";i:0;}i:2;a:2:{s:6:"format";s:11:"image_plain";s:7:"exclude";i:0;}i:3;a:2:{s:6:"format";s:11:"image_plain";s:7:"exclude";i:0;}}

Here's the new:

a:14:{s:15:"file_extensions";s:16:"png gif jpg jpeg";s:9:"file_path";s:0:"";s:18:"progress_indicator";s:3:"bar";s:21:"max_filesize_per_file";s:2:"1M";s:21:"max_filesize_per_node";s:2:"5M";s:14:"max_resolution";s:1:"0";s:14:"min_resolution";s:7:"150x150";s:3:"alt";s:0:"";s:10:"custom_alt";i:0;s:5:"title";s:0:"";s:12:"custom_title";i:0;s:10:"title_type";s:9:"textfield";s:13:"default_image";N;s:17:"use_default_image";i:0;}

a:7:{s:5:"label";a:2:{s:6:"format";s:5:"above";s:7:"exclude";i:0;}s:6:"teaser";a:2:{s:6:"format";s:11:"image_plain";s:7:"exclude";i:0;}s:4:"full";a:2:{s:6:"format";s:11:"image_plain";s:7:"exclude";i:0;}i:4;a:2:{s:6:"format";s:11:"image_plain";s:7:"exclude";i:0;}i:2;a:2:{s:6:"format";s:11:"image_plain";s:7:"exclude";i:0;}i:3;a:2:{s:6:"format";s:11:"image_plain";s:7:"exclude";i:0;}s:5:"token";a:2:{s:6:"format";s:11:"image_plain";s:7:"exclude";i:0;}}

@gallamine

It sounds more likely that you where using an older version of FileField Paths for your original field and since upgraded to a more current version. I say this as the previous version used the standard Filepath field which then allowed ImageField or FileField to save the data as well, whereas the current version does not. Also, the values stored in the ImageField/FileField widget settings are not used by FileField Paths and are therefore not related to this issue.

There is nothing wrong with ImageField, so I would suggest closing that issue if you have opened one.

I would suggest trying out the patch in #18 as while I haven't been able to reproduce this issue, the solution provided is sound.

Cheers,
Deciphered.

@Deciphered

Thanks for the input. I figured these type of things should have been taken care of by the upgrade path, so that's why I was confused/concerned.

I tried the patch, and it takes care of the preg_match() problem. Thanks!

Just had this issue. Raising the issue from dead, but I want to share how I solved it.
Solution:
1. Disable filefield_paths
2. Remove any settings that you have in file path (you probably have some token there - that is the reason for warning) for your field
3. Enable filefield_paths
4. Check file path for your field (if you didn't uninstall filefield_paths, it should be remembered)
That's it. ;)

It seams that module gets confused if there is a token in file path for filefield (as gallamine already noticed).

No longer supporting Drupal 6 issues for this module.