this started in #595930: from github to d.o cvs(aka start 6.x-2.0-dev and get access)

quoting sdboyer:

- How much are we _really_ gaining from using ArrayAccess? Seems like just a backwards-compat thing, and I'd rather not (ever) support that, per the typical Drupal approach.

ArrayAccess was sooo useful on converting to OOP that I forgot to remove it, so let''s do it.

In the other hand, maybe the patch to do here as reverse could help other backends in the process of chaging the api, but anyway, we need to remove it.

CommentFileSizeAuthor
#10 0001-task-723958-Remove-ArrayAccess-dependency-everywhere.patch7.01 KBmarvil07
#7 0001-723958-Remove-ArrayAccess-dependency-everywhere.patch12.86 KBmarvil07

Comments

CorniI’s picture

CorniI commented

well, for example commitlog still depends on it, and there are probably other places depending on ArrayAccess as well. Can you just post a branch which removes all the ArrayAccess implementations? I'll then look at vcs_git to clean that up.

marvil07’s picture

marvil07 commented
Title: remove ArrayAccess dependency everywher » remove ArrayAccess dependency everywhere
Priority: Normal » Major
marvil07’s picture

marvil07 commented
Issue tags: +git phase 2

We do not want to release a stable without making sure oo-ification is completed ;-), IIRC the main amount of work is going to be at backends.

marvil07’s picture

marvil07 commented

This also involves that we are sure we are not anymore using objects as arrays anywhere.

marvil07’s picture

marvil07 commented
Issue tags: +git sprint 7

Tagging for consideration on planning meeting.

marvil07’s picture

marvil07 commented
Assigned: Unassigned » marvil07
marvil07’s picture

marvil07 commented
Title: remove ArrayAccess dependency everywhere » Remove ArrayAccess dependency everywhere
Status: Active » Needs work
StatusFileSize
new 0001-723958-Remove-ArrayAccess-dependency-everywhere.patch12.86 KB

This change actually has been tried to solve on many other commits indirectly.

Here a patch that tries to solve the rest of it, lots of code, so this is uploaded as first attempt. In the other side, if we apply this patch soon, it is going to be a nightmare to follow the patch on #983926: Remove account class :-/ (I really want to postpone this until that is committed)

eliza411’s picture

eliza411 commented
Issue tags: +git sprint 8

Tagging Git Sprint 8

sdboyer’s picture

sdboyer commented

Oh man, thanks for grabbing this - it's been hanging around FOREVER. Course, the patch doesn't apply so well, now...if you don't have time to reroll it, I will soon.

marvil07’s picture

marvil07 commented
Status: Needs work » Fixed
StatusFileSize
new 0001-task-723958-Remove-ArrayAccess-dependency-everywhere.patch7.01 KB

So, here the patch I committed(seems like a RTBC as #9).

Status: Fixed » Closed (fixed)
Issue tags: -git phase 2, -git sprint 7, -git sprint 8

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +git phase 2, +git sprint 7, +git sprint 8

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.

  • Commit 5e67645 on repository-families, drush-vc-sync-unlock by marvil07: 
    task #723958: Remove ArrayAccess dependency everywhere.

  • Commit 5e67645 on repository-families by marvil07: 
    task #723958: Remove ArrayAccess dependency everywhere.