Jump to:
| Project: | Version Control API |
| Version: | 6.x-2.x-dev |
| Component: | API module |
| Category: | task |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | postponed |
| Issue tags: | git phase 2 leftovers, versioncontrol-6.x-2.0-release-blocker |
Issue Summary
this started in #595930: from github to d.o cvs(aka start 6.x-2.0-dev and get access)
quoting sdboyer:
BTW, there's been movement on coding standards since I think we last talked - http://drupal.org/coding-standards and http://drupal.org/node/608152 . Yes, more Crell (and me) :) I see why we were using them - indicating a public method that is really only intended to be called by the backend - but I'd still rather we use something other than underscores. I like your idea:
In this case, like other "underscored methods", I use it for forcing a "good" workflow, letting a fallback; but maybe is a good idea to rename the underscored method to a with a new "identifier"/name instead of _
So, we need to evaluate a good way to follow standards as much as possible and also and mainly letting the code to be as understandable as possible.
Comments
#1
After #879858: Unify entity C(R)UD most of underscored methods are changed to
backend<crud_operation>(), so less things to do here.Leaving this open to actually make a review across all the code and another one with coder module.
#2
#3
We should have an outside party do this (and a security review) prior to stable release, but not just yet.
#4
Wow, this is the least critical path issue marked git phase 2 that i've untagged today :)
#5
let's do this review before 6.x-2.0