The output to the account page could do with work on several fronts.

First, what we output ends up inside a DL no matter what we do -- it's just the way user module works. Currently we get bare text inside a DL, which is invalid HTML.

Second, I'm really not sure about the grouping being that high up. Top-level categories on the account page should be for pretty big things: both user and blog modules put their stuff under 'History' for instance. Currently we have a top-level category for each vocabulary if grouping is turned off. It would make more sense to have one heading for 'Taxonomy terms', and then DL headings for each vocabulary. (Though: what that heading should actually be: #689508: change user account form fieldset label).

Which brings us to the grouping. This isn't a feature I use, but the idea seems to be to show all terms in one list, with no vocabulary headings. That's easily accommodated in the change.

Comments

joachim’s picture

Status: Active » Needs review
StatusFileSize
new3.83 KB

Patch also changes from a BRs separating terms to using theme_item_list() on them.

joachim’s picture

Status: Needs review » Fixed

#724880 by joachim: Fixed use of hook_user view API to produce compliant HTML and grouped all terms under a single top-level category.

Committed the patch.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.