Fatal error when saving forum administration form

I suppose this qualify as critical since it's technically not possible to rearrange the forums (and their containers).

Definitely seems critical to me. Here's a test for the form so that we can catch this in the future.

Also, I looked into that function a bit and couldn't find where it went or how this form ever worked. I probably wasn't looking in enough places.

Ok, here we go.

That validate function was added in #193333-24: Add drag and drop to taxonomy. In Drupal 6 a $form['#validate'] function that doesn't exist will be silently ignored. In Drupal 7 it's a fatal error.

Since this function has never existed I think it's safe to simply remove it.

looks like an easy fix. there was a similar issue with locale in D6 where a validate/submit function never existed and was only discovered recently via Drupal 7.

x-post

These errors with JavaScript file created: not found on locale.test happen from time to time.

#5: 725148_5_forum_admin_function_not_found_with_tests.patch queued for re-testing.

back to RTBC

Woohoo http://drupal.org/cvs?commit=339624

We could do this to 6.x as well just for consistency, but it seems unnecessary to me.