Using quicktabs and skinr isn't really fun. Somehow skinr applies itself to the content the tab activates and sees it as a block inside a block. Played with various settings but the problem persits. The attached picks show the "best" state. The first pick shows what happens when the active tab shows a node and the second one demonstrates the behaviour with a view block.

Theme Acquia Marina 3, quicktabs 2.4 rc1

Is that something skinr can handle or has that to be done by quicktabs?

Comments

dddave’s picture

StatusFileSize
new27.52 KB
new5.53 KB
new7.98 KB

Forgot some details:

The blocks are shown with AM block title style "blue background + white text" and AM rounded corners. Disabling the rounded corners for the "outer" block and activating them for the inside block is attached in the new pic. Disabling all styles works well (of course).

Pic 2 show the skinr wheels to demonstrate the block inside a block situation.

Pic 3 shows signs of rounded corners for the node but at least the placement is correct (float left which doesn't work with the view block).

jacine’s picture

Project: Skinr » Acquia Marina
Version: 6.x-1.5 » 6.x-3.0-alpha1

I'm confused. What does this have to do with Skinr?

Seems like straight up CSS issues that need to be addressed in the theme, so I'm changing the project. If you think that's wrong, feel free to change it back and explain why, but understand that Skinr is only providing a means to setup styles and provide classes. Themes are responsible for their own CSS.

Also, the "skinr wheels" you mention are coming from Fusion (I think?). Skinr isn't doing those.

dddave’s picture

Sorry for the misunderstanding. My bad.

jacine’s picture

No problem. It's easy to get confused :)

jeremycaldwell’s picture

StatusFileSize
new27.85 KB

Hi ddave, I tried replicating the issue you are having with your Skinr settings and the Acquia Marina theme but was unsuccessful. I created a Quicktabs block and set the Skinr style of "Blue background with white text" and the rounded corners, and it appears just fine for me. Attached is a screenshot. It's a Quicktabs block of two blocks, not Views blocks.

dddave’s picture

This is mindboggling...

O.K. here are my findings so far:

1. Using a block in a Quicktabs block that is already used at another location on the site causes problems. Some stylesettings given there "transfer" into the quicktabs block. Not all (e.g. icons) but some (e.g. block position float right). This explains some of my wierd positioning errors.

2. Using system blocks like "New Blog entries" is a no no. This explains (sort of) why skinr is so eager to go for the block INSIDE the quicktabsblock.

3. Using a block provided by views works fairly well (no positioning errors) yet rounded corners are applied arround the inner content...at least when the content fetched by views are whole nodes and not fields (seems to be the pattern here).

If you want to make this mess extra visible let the quicktabs block display the title of the displayed item ( if this item is a block of course). The settings for the quicktabs block like ""Blue background with white text" are also applied to the displayed block inside the quicktabs block even if you disable them for the block "inside".

Hope this makes some sense.

jeremycaldwell’s picture

Thanks dddave, that sounds correct and normal. If you apply a Skinr style to a block and use it somewhere and then want to use that same block in a Quicktabs configuration it will still have that Skinr style applied to it and use it. So sounds like you need to have two different version of the same block if you want one styled and on its own and then one in Quicktabs unstyled.

g089h515r806’s picture

i have the same issue, it works well in forefox, but conflict in IE7.

stephthegeek’s picture

Status: Active » Postponed (maintainer needs more info)

Ok I'm trying to sort out exactly what remains here in this issue but it is also hurting my brain to follow :)

It's true that some style combinations inside blocks inside a quicktabs block are not going to work too well together. In fact, I'd venture that in *most* cases, applying a Skinr style to the outer QT block is not going to work well because the blocks inside all have the .inner div which will pick up the styling.

So, some custom tweaking will be needed for QT blocks, at least until IE6 isn't in the picture at all and we can use child selectors more.

Same deal with full nodes, because these also have the .inner on them, and if you end up with a page view inside something with a skinr class applied to it (eg. a panel pane).

That being said, there *shouldn't* be browser-specific issues for these (they're universal issues), nor should there be issues with any system blocks or views blocks.

I don't want to leave you hanging here so some specific examples of things that are still issues or not clear would be really helpful.

mrtbc’s picture

Did anyone ever find a fix to this please? Can CSS changes be made to fix a couple of specific blocks?

stephthegeek’s picture

I don't think there is a universal "fix" here. A link to a specific problem would help. I think most of the issues related to skins + Quicktabs are going to be a matter of case-specific CSS tweaks.

mrtbc’s picture

Thanks for the reply. Here is my test page showing the problem:

http://tinyurl.com/3pzyqf4

You can see the problem in the block above the main view content. I have added the two individual blocks at the very bottom so you can see the difference.

Thank you.

goody815’s picture

hi mrtbc,

do you have a mockup of what you want it to look like? are you wanting that inner rounded corner styling removed?

goody815’s picture

Assigned: Unassigned » goody815
mrtbc’s picture

Hey, thanks for replying. Yes, that is exactly what I want to do. Basically I'd like to remove the inner rounded corners and also reduce the inner margins a little.

goody815’s picture

mrtbc,

Stephthegeek probably put it the best as there isn't a one specific fix. I would suggest using firebug and tweeking the css that is specific to that quicktab inner area, then saving it to your local.css file

mrtbc’s picture

Thanks, I did manage to do this.

goody815’s picture

Status: Postponed (maintainer needs more info) » Closed (fixed)

mrtbc,

thanks for the update. glad you were able to solve it with some creative css and firebug. I'm going to go ahead and close this issue then.