If you happen to add a component where trim($component) === '', there is no way to remove it.
This is because:
(1) component names are saved trimed() in the database (in project_issue_project_edit_form_submit()); and because
(2) the component name is used as a key in project_issue_project_edit_form_submit(), which result in a input tag with name="component[][name]" being generated.
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | empty-component-725448-5.patch | 2.64 KB | mikey_p |
| #4 | empty-component-725448-4.patch | 2.63 KB | mikey_p |
| #2 | empty-component-725448-2.patch | 2.69 KB | mikey_p |
Comments
Comment #1
dwwBummer. ;) We shouldn't let you save them in the first place, then. ;) But yeah, we need to fix this. I know core has an empty component, and that sucks.
It'd be nice to fix this before 6.x-1.0, but I don't think it's a blocker, so adding it to the wishlist...
Comment #2
mikey_p commentedThis should do the trick, and it includes a batch update function to go through project_issue_projects and update rows with empty components.
I named the update function assuming the #175555: Add custom Priority Levels would land first.
Comment #3
mikey_p commentedWhoops, left a dsm in there.
Comment #4
mikey_p commentedI still can't get the form_set_error to correctly highlight the element that it's set on. I've talked to chx about this and it doesn't seem to be anything obvious.
Comment #5
mikey_p commentedBlargh, typo.
Comment #6
mikey_p commentedMoving some of the work I had on github to topic branches on d.o: http://drupalcode.org/project/project_issue.git/shortlog/refs/heads/7254...