Posted by morningtime on February 25, 2010 at 7:06pm
Issue Summary
RTL looks good, but hovering over top level menu items shows no dropdowns... No JS error at all. In Firebug I see the
- style change from left:-999 to left:auto, but Im wondering if this should be reversed, e.g. right:-999 to right:auto?
Comments
#1
I've found out that the JavaScript part messes up the offSetLeft value (position) for the dropdown menu div. In LRT a value may be offSetLeft: 318, the same menu in RTL gets a value of offSetLeft: -90 (clearly, that means off screen).
Have to dig deeper to find the wrong calculation.
#2
same problem.
In RTL languages FF3.6 does not expand sub-menus.
It works fine in IE7.
#3
The whole off-left method is very bad for RTL. I suggest changing it to off-top instead.
For more details, see a post I've just wrote about this issue http://www.held.org.il/blog/?p=260
#4
My experience with RTL is limited. First of all, I need qualified input.
In LTR, elements that exceed the max-width of BODY cause a horizontal scrollbar. Therefore
right: -999emdoes not work.Do browsers flip the entire rendering logic? So aforementioned
right: -999emwill not cause a scrollbar, butleft: -999emwill? (I doubt that + recall that I tested it once)If they are not, then this issue is caused by our RTL styles, but the involved JS does not account for the flipped RTL styles. This means that we need to update the JS to remove the styles instead of resetting them to
auto.#5
I experience the same with Administration menu 6.x-3.0-alpha4 on a RTL site. I hope that this will be fixed in future releases. It looks like a nice add on.
#6
Where do you think the problem is located ?! The js file or the rtl css file ?!
#7
I would happily test any suggestions / patches. This is a great module and I think we should work together on making it available to all people / all languages.
I am sure the problem is caused by a minor specification in the current code. It shows perfectly but no dropdown on RTL sites.
#8
Finally SOLVED!
This solution concerns the latest dev version for Drupal SEVEN (November 14th):
a. Replace every "left" with "right" inside the admin_menu.js file
b. I have made small modification to the "admin_menu-rtl.css" file. Look at the attachment. Replace yours with this one.
Developers: please review and see if there are more professional ways to do this.
Admin menu on RTL ! Finally !
Tested with Firefox (3.6.12) and Drupal SEVEN RC-2
#9
Continues from my last post:
The same applies to the 6.x dev branch. Modify the js file and make similar changes to the respective rtl.css file as outlined above.
Enjoy it!
#10
I understand the logic, but it going to cause me a problem because i have multi-lingual sites, that need rtl and ltr support for administrators!
#11
Same issue in 7.x-3.x-dev (Jan 30) in Chrome and Firefox on windows.
#12
Please use the attachment on the next post (#13) do not use this one. TKS
#13
Hello,
Revised admin_menu_init(), admin_menu.js and admin_menu-rtl.css.
Tested on Google chrome & Opera. Works for me.
You are welcome to give it a try.
#14
tested the update in Chrome 10, IE9, and Firefox 4. Drop down menu works finally, but we have some minor issues with second-level sub-menus jumping to the right sometimes, on all tested browsers.
please commit this update.
thanks.
#15
works for me for all levels of submenus!
can't this fix be implanted in the next version?
#16
solved it with css:
#admin-menu-wrapper { overflow: visible; }
* for 7.x-3.0-rc1 version
#17
#1297862: No dropdown menus in RTL language has been marked as duplicate of this issue. Seems to contain #16 as patch.