I have noticed the following cases which I do not feel are desireable.

-//  function testFieldFormMultiple() {
-//    $this->field = $this->field_multiple;
-//    $this->field_name = $this->field['field_name'];
-//    $this->instance['field_name'] = $this->field_name;
-//    field_create_field($this->field);
-//    field_create_instance($this->instance);
-//  }
+  //  function testFieldFormMultiple() {
+  //    $this->field = $this->field_multiple;
+  //    $this->field_name = $this->field['field_name'];
+  //    $this->instance['field_name'] = $this->field_name;
+  //    field_create_field($this->field);
+  //    field_create_instance($this->instance);
+  //  }

-  /**
+/**
    * TODO:
    * - Test field visibility
    * - Test profile browsing

-    if ($contact !== TRUE) { // If true then attempting to find error message.
+    if ($contact !== TRUE) {
+ // If true then attempting to find error message.

In order to make this work the most consistently and easiest I vote for treating the first two as the same case and fix the last one to leave comment on previous line.

The first two just need to leave whatever spacing existed in front of the comment. In fact you might just do that always...thus the { // case would be the same in that it is prefixed by " " and not "\n ".

Comments

boombatower’s picture

boombatower commented

After discussion the other cases make sense, except that the comment on the if is not indented...and that preferably it should be placed on the preceding line.

Still looks like block comment formatting is messed up:

  /**
   * TODO:
   * - Test field visibility
   * - Test profile browsing
   * - Test required fields
   * - Test fields on registration form
   * - Test updating fields
   */

to

/**
   * TODO:
   * - Test field visibility
   * - Test profile browsing
   * - Test required fields
   * - Test fields on registration form
   * - Test updating fields
   */

Should be left alone.

solotandem’s picture

solotandem commented
Assigned: Unassigned » solotandem
Status: Active » Fixed

Fixed in next dev release.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.